Skip to content

Bump to 2.5.0, make compatible with Unity 6.0+#428

Open
aurimasc wants to merge 13 commits intomasterfrom
unity-6.0
Open

Bump to 2.5.0, make compatible with Unity 6.0+#428
aurimasc wants to merge 13 commits intomasterfrom
unity-6.0

Conversation

@aurimasc
Copy link
Copy Markdown
Collaborator

@aurimasc aurimasc commented Apr 8, 2026

https://jira.unity3d.com/browse/PLAT-19430
No (intentional) functional changes.
Make package compatible with Unity 6.0 or later (previously was 2021.3 or later).
Package version increased to 2.5.0 (required min version bump due to Unity compatibility bump).
Increasing minimum supported Unity version will allow cleanup to be done as it means minimum supported Android version is now higher too. No changes for this made here, will be follow up.
Most changes in this PR are test project upgrades to Unity 6, CI updates to only test on supported versions.
The only code changes are Android-specific deletions of code behind version defines. Automated test should fully over those (did try build locally too).

@aurimasc aurimasc requested review from a team and todi1856 April 9, 2026 15:16
@todi1856
Copy link
Copy Markdown
Member

/crc

@u-pr
Copy link
Copy Markdown

u-pr bot commented Apr 10, 2026

May require changes
The review identified concerns regarding test coverage, performance, and error handling:

  • Test Coverage: Existing tests for Android manifest injection were removed during the refactor without clear replacements.
  • Performance: JNI lookups in AndroidNotificationCenter could benefit from caching to avoid repeated overhead.
  • Error Handling: Standard .NET exception types should be used for missing JNI fields and methods for better clarity.

🤖 Helpful? 👍/👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants