Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
PR Code Suggestions ✨No code suggestions found for the PR. |
glabute
left a comment
There was a problem hiding this comment.
Nice catch! And good fix.
I made a small comment, which is a suggestion for clarity.
| if (cam == null || (cam.State.BlendHint & CameraState.BlendHints.FreezeWhenBlendingOut) == 0) | ||
| { | ||
| // No snapshot required - reset it | ||
| m_Snapshot.TakeSnapshot(null); |
There was a problem hiding this comment.
Should call ClearSnapshot() here, for clarity
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
+ Coverage 17.07% 17.14% +0.06%
==========================================
Files 209 209
Lines 23759 23768 +9
==========================================
+ Hits 4058 4074 +16
+ Misses 19701 19694 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Purpose of this PR
Fixed UUM-131151 (public issue)
Testing status
Tested the 3d samples + added an automated test
Documentation status
No doc needed, this is a bugfix
Technical risk
Tech risk: low, halo effect: low
Comments to reviewers
Package version
[Justification for updating either the patch, minor, or major version according to the semantic versioning rules]