DOCS: Feedback for docs#2456
Conversation
|
|
Updating link... but I have a bad feeling about this link format
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2456 +/- ##
========================================
Coverage 78.95% 78.95%
========================================
Files 767 767
Lines 140780 140780
========================================
Hits 111158 111158
Misses 29622 29622
Flags with carried forward coverage won't be shown. Click here to find out more. |
| ## MultiTap | ||
|
|
||
| A [`MultiTapInteraction`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) requires the user to press and release a Control within [`tapTime`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) seconds [`tapCount`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) times, with no more then [`tapDelay`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) seconds passing between taps, for the Interaction to trigger. You can use this to detect double-click or multi-click gestures. | ||
| You can use `MultiTap` to detect double-click or multi-click gestures. For a [`MultiTapInteraction`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) to trigger, the user must press a control and release it within [`tapTime`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) seconds, repeating the press-and-release process [`tapCount`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) times. There can't be more than [`tapDelay`](xref:UnityEngine.InputSystem.Interactions.MultiTapInteraction) seconds between taps. |
There was a problem hiding this comment.
While touching the MultiTap section, the default-value table just below still says tapDelay defaults to 2 * tapTime. The implementation actually falls back to InputSettings.multiTapDelayTime when tapDelay is unset, so this section still documents the wrong default spacing between taps and will mislead anyone tuning multi-click timing. Please update the table row to match the runtime behavior.
🤖 Helpful? 👍/👎
There was a problem hiding this comment.
yep, u-pr is right (even though your changes are not affecting it; it just found out another doc inconsistency with the implementation)
There was a problem hiding this comment.
Can you check my change, please? I basically copy/pasted u-pr.
jpriyas
left a comment
There was a problem hiding this comment.
Thanks for the changes. Just added a couple of suggestions.
From Priya's review
From tech review
Description
User feedback for docs.
Testing status & QA
Docs only
Overall Product Risks
Docs only
Comments to reviewers
Docs only.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.