Skip to content

CHANGE: XRI test ignored as it is causing issues in the CI. It should be re-enabled once the underlying issue is resolved#2390

Merged
josepmariapujol-unity merged 1 commit intodevelopfrom
input/disable-xri
Mar 19, 2026
Merged

CHANGE: XRI test ignored as it is causing issues in the CI. It should be re-enabled once the underlying issue is resolved#2390
josepmariapujol-unity merged 1 commit intodevelopfrom
input/disable-xri

Conversation

@josepmariapujol-unity
Copy link
Collaborator

@josepmariapujol-unity josepmariapujol-unity commented Mar 19, 2026

Description

XRI test ignored as it is causing issues in the CI. It should be re-enabled once the underlying issue is resolved.

Reason:
Library/PackageCache/com.unity.xr.interaction.toolkit@e986f3a5995f/Editor/Debugger/XRTargetFiltersTreeView.cs(243,28): error CS0619: 'EntityId.implicit operator EntityId(int)' is obsolete: 'EntityId will not be representable by an int in the future. This casting operator will be removed in a future version.'

CI now:
Screenshot 2026-03-19 at 10 58 47

Slack: https://unity.slack.com/archives/C95QR0BNJ/p1773843670885359

JIRA: https://jira.unity3d.com/browse/ISX-2531

Testing status & QA

Check CI is skipping this test.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity:0
  • Halo Effect:0

Comments to reviewers

Please describe any additional information such as what to focus on, or historical info for the reviewers.

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

Copy link
Contributor

@u-pr u-pr bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect
I've completed the review. Only a minor naming issue was identified.

🤖 Helpful? 👍/👎

@josepmariapujol-unity josepmariapujol-unity self-assigned this Mar 19, 2026
@codecov-github-com
Copy link

codecov-github-com bot commented Mar 19, 2026

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff            @@
##           develop    #2390    +/-   ##
=========================================
  Coverage    77.90%   77.91%            
=========================================
  Files          476      482     +6     
  Lines        97613    97756   +143     
=========================================
+ Hits         76048    76169   +121     
- Misses       21565    21587    +22     
Flag Coverage Δ
inputsystem_MacOS_2022.3 5.30% <ø> (-0.23%) ⬇️
inputsystem_MacOS_2022.3_project 75.35% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.0 5.27% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.0_project 77.26% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.3 5.27% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.3_project 77.25% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.4 5.28% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.4_project 77.27% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.5 5.28% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.5_project 77.26% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.6 5.28% <ø> (-0.04%) ⬇️
inputsystem_MacOS_6000.6_project 77.26% <ø> (-0.05%) ⬇️
inputsystem_Ubuntu_2022.3_project 75.15% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.0 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.06% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.3 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.06% <ø> (-0.05%) ⬇️
inputsystem_Ubuntu_6000.4 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.4_project 77.07% <ø> (-0.05%) ⬇️
inputsystem_Ubuntu_6000.5 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.06% <ø> (-0.05%) ⬇️
inputsystem_Ubuntu_6000.6 5.28% <ø> (-0.04%) ⬇️
inputsystem_Ubuntu_6000.6_project 77.07% <ø> (-0.04%) ⬇️
inputsystem_Windows_2022.3 5.30% <ø> (-0.23%) ⬇️
inputsystem_Windows_2022.3_project 75.48% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.0 5.27% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.0_project 77.38% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.3 5.27% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.3_project 77.38% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.4 5.28% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.4_project 77.38% <ø> (-0.05%) ⬇️
inputsystem_Windows_6000.5 5.28% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.5_project 77.39% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.6 5.28% <ø> (-0.04%) ⬇️
inputsystem_Windows_6000.6_project 77.39% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
Assets/Tests/InputSystem.Editor/XRIPackageTest.cs 91.30% <ø> (ø)

... and 8 files with indirect coverage changes

@josepmariapujol-unity
Copy link
Collaborator Author

XRI team has been told to revert this PR once they land their fix to the package

@josepmariapujol-unity josepmariapujol-unity merged commit 0bb75c4 into develop Mar 19, 2026
121 of 128 checks passed
@josepmariapujol-unity josepmariapujol-unity deleted the input/disable-xri branch March 19, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants