Add autocomplete choices to RankBy in getFundamentals#122
Open
matteozanettii wants to merge 1 commit into
Open
Add autocomplete choices to RankBy in getFundamentals#122matteozanettii wants to merge 1 commit into
matteozanettii wants to merge 1 commit into
Conversation
Added choices for 'char' and 'string' types in RankBy function signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added choices for 'char' and 'string' types in RankBy function signature.
Proposed changes
Description
This PR implements the UX enhancement proposed in Issue:
I added the
choices={...}array to both thecharandstringtypes for theRankByparameter infunctionSignatures.json. The list includes the most commonly used financial metrics to provide a quick and clean autocomplete experience without overwhelming the user with all 176 possible fields.Types of changes