test(voice): pin output envelope passthrough in session end detail#1794
Open
mjnovice wants to merge 1 commit into
Open
test(voice): pin output envelope passthrough in session end detail#1794mjnovice wants to merge 1 commit into
mjnovice wants to merge 1 commit into
Conversation
The voice bridge already preserves the full voice_session_ended payload opaquely; this pins the upcoming output envelope (fields/status/extracted) and endToolCalled specifically so the passthrough contract cannot regress. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test to pin the “voice_session_ended end_detail passthrough” contract for the upcoming CAS output envelope shape, ensuring downstream consumers can rely on those fields being preserved.
Changes:
- Adds a new async test covering
voice_session_endedpayloads that include the CASoutputenvelope (fields/status/extracted) and top-levelendToolCalled.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+93
to
+94
| assert session.end_detail["output"] == envelope | ||
| assert session.end_detail["endToolCalled"] is True |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only companion to UiPath/uipath-agents-python#599 (voice conversational-agent outputs workstream).
The voice bridge already stores the full
voice_session_endedpayload opaquely inend_detail(deep-copied, unknown keys preserved — shipped in #1764). The upcoming CAS output envelope (output: {fields, status, extracted}+ top-levelendToolCalled) therefore needs no functional change here — this PR adds one test pinning that specific shape so the passthrough contract can't regress silently while the reader (uipath-agents-python#599) depends on it.Test plan
uv run pytest tests/cli/chat/test_voice_bridge.py— 15 passedruff check/ruff formatclean🤖 Generated with Claude Code