-
Notifications
You must be signed in to change notification settings - Fork 25
fix(tracing): set Traces source to CodedAgents #1626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -389,7 +389,7 @@ def _process_span_attributes(self, span_data: Dict[str, Any]) -> None: | |||
| def _build_url(self, span_list: list[Dict[str, Any]]) -> str: | ||||
| """Construct the URL for the API request.""" | ||||
| trace_id = str(span_list[0]["TraceId"]) | ||||
| return f"{self.base_url}/api/Traces/spans?traceId={trace_id}&source=Robots" | ||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are we sure this won t break low code?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @saksharthakkar / @JosephMar could validate this change from a tracing perspective
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also needs to be changed
source exists both inside the model and on the query path (for convenience) |
||||
| return f"{self.base_url}/api/Traces/spans?traceId={trace_id}&source=CodedAgents" | ||||
|
|
||||
| def _send_with_retries( | ||||
| self, url: str, payload: list[Dict[str, Any]], max_retries: int = 4 | ||||
|
|
||||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we also re-generate the
uv.lock?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably