fix: ixp extraction tool#821
Merged
cristian-groza merged 3 commits intomainfrom May 5, 2026
Merged
Conversation
andreitava-uip
approved these changes
May 5, 2026
Comment on lines
+37
to
+44
| 1. `BaseTool._parse_input()` extracts each field with `getattr(model, key)`, | ||
| where `key` is the alias. For aliases that collide with built-in model | ||
| attributes (e.g. `schema`), this returns the built-in instead of the | ||
| field value, so downstream `kwargs.get("id") / kwargs.get("full_name")` | ||
| came back as `None`. | ||
| 2. `tool_call_schema` rebuilds a subset of the model by copying each field | ||
| but drops alias and serialization options, so the rebuilt schema no | ||
| longer matches what the LLM emits. |
Contributor
There was a problem hiding this comment.
nit: these bugs are not what causes it. It was us fixing the bugs via our structured tool subclass that surfaced the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken IXP extraction tool invocation caused by LangChain's mishandling of pydantic field aliases.
Problem
After PR #796 switched the extraction tool's args_schema to Attachment, tool calls started failing — kwargs.get("id") and kwargs.get("full_name") came back as None, so attachments.download_async was called with key=None.
Two LangChain bugs are at play:
Attachment aliases every field (id → ID, full_name → FullName, …), so it hits both bugs.
Fix
Introduce ExtractionToolInputSchema — an alias-free mirror of Attachment with the same python field names and annotations — and use it as the tool's args_schema. Sidesteps both LangChain bugs until they're fixed upstream.
Changes
Attachment evolves.
Test plan