feat(apollo-vertex): add customize appearance — color utilities and branding store#678
Open
petervachon wants to merge 1 commit into
Open
feat(apollo-vertex): add customize appearance — color utilities and branding store#678petervachon wants to merge 1 commit into
petervachon wants to merge 1 commit into
Conversation
…randing store Adds the data layer for the Customize Appearance pattern: - color-utils.ts: pure oklch↔hex conversion functions used by the color pickers; no React dependencies, safe to import anywhere - branding-store.ts: external store (useSyncExternalStore) for BrandingSettings (app title, logo URL, primary/accent colors, theme mode). Ships with a localStorage-backed default adapter; the BrandingAdapter interface is designed to be swapped for a server-side implementation (e.g. Data Fabric) so that branding changes are visible across users Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
petervachon
requested review from
alincadariu and
ruudandriessen
and removed request for
a team
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
4 tasks
Contributor
Dependency License Review
License distribution
Excluded packages
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
color-utils.ts— pure oklch↔hex conversion functions for the color pickers; no React dependenciesbranding-store.ts— external store (useSyncExternalStore) holdingBrandingSettings(app title, logo URL, primary/accent colors, theme mode)localStorage-backed default adapter; theBrandingAdapterinterface is designed to be swapped for a server-side implementation (e.g. Data Fabric) so branding changes are visible across usersTest plan
useBrandingStorein a component and verify reads/writes round-trip through the storeoklchToHex/hexToOklchStringproduce valid values for known inputs🤖 Generated with Claude Code