feat(apollo-vertex): add settings template#677
Open
petervachon wants to merge 1 commit into
Open
Conversation
Adds a traditional settings page composition under Templates: a vertically-stacked workspace settings form with Profile, Notifications, Regional, and Privacy & security sections. Demonstrates Field, Input, Textarea, Select, RadioGroup, and Switch primitives on the foundation grid, with the form column constrained to lg:col-span-7 for readable line lengths and Switch rows using FieldContent for proper title-over-description layout. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
petervachon
requested review from
angeloaltamiranom and
pieman1313
and removed request for
a team
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
pieman1313
requested changes
May 19, 2026
Comment on lines
+127
to
+154
| const [draft, setDraft] = useState<SettingsDraft>(INITIAL_DRAFT); | ||
| const [saved, setSaved] = useState<SettingsDraft>(INITIAL_DRAFT); | ||
|
|
||
| const hasChanges = | ||
| draft.workspaceName !== saved.workspaceName || | ||
| draft.description !== saved.description || | ||
| draft.industry !== saved.industry || | ||
| draft.emailFrequency !== saved.emailFrequency || | ||
| draft.emailDigest !== saved.emailDigest || | ||
| draft.browserPush !== saved.browserPush || | ||
| draft.language !== saved.language || | ||
| draft.timezone !== saved.timezone || | ||
| draft.dateFormat !== saved.dateFormat || | ||
| draft.visibility !== saved.visibility || | ||
| draft.require2fa !== saved.require2fa; | ||
|
|
||
| const updateField = <K extends keyof SettingsDraft>( | ||
| key: K, | ||
| value: SettingsDraft[K], | ||
| ) => { | ||
| setDraft((prev) => ({ ...prev, [key]: value })); | ||
| }; | ||
|
|
||
| const handleSave = () => setSaved(draft); | ||
| const handleReset = () => { | ||
| setDraft(INITIAL_DRAFT); | ||
| setSaved(INITIAL_DRAFT); | ||
| }; |
Contributor
There was a problem hiding this comment.
I see we are using react hook form in vertex, can we switch to showcasing that here instead of the manual plumbing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Field,Input,Textarea,Select,RadioGroup, andSwitchprimitives composed on the foundation gridlg:col-span-7for readable line lengths; full-width on mobile/tabletSave changesbutton — no external state library neededTest plan
/templates/settingsin the preview — all four sections render (Profile, Notifications, Regional, Privacy & security)🤖 Generated with Claude Code