fix(apollo-wind): address theming gaps for apollo-react/canvas [MST-8290]#487
Merged
BenGSchulz merged 1 commit intomainfrom Apr 10, 2026
Merged
fix(apollo-wind): address theming gaps for apollo-react/canvas [MST-8290]#487BenGSchulz merged 1 commit intomainfrom
BenGSchulz merged 1 commit intomainfrom
Conversation
Contributor
BenGSchulz
commented
Apr 10, 2026
- Skeleton + Dropdown item separator use surface-overlay and properly show in light theme
- Badge supports status variants, tailwind css updated to support status utility classes
- Export TooltipPortal primitive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
Pull request overview
This PR addresses Apollo Wind theming gaps (notably for the canvas theme) and expands component capabilities by adding status-aware badge variants and exporting an additional Tooltip primitive.
Changes:
- Updated Tailwind consumer theme variables/mappings to support status background utilities and improve canvas theme compatibility.
- Switched Skeleton and DropdownMenu separator styling to use
surface-overlayfor better theme correctness. - Added Badge status variants (success/warning/error/info) and exported
TooltipPortal.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/apollo-wind/src/styles/tailwind.consumer.css | Adds status background variables per theme and adjusts Tailwind token mappings used to generate utilities (incl. canvas bridging). |
| packages/apollo-wind/src/index.ts | Re-exports TooltipPortal from the tooltip module. |
| packages/apollo-wind/src/components/ui/tooltip.tsx | Exposes Radix TooltipPrimitive.Portal as TooltipPortal. |
| packages/apollo-wind/src/components/ui/skeleton.tsx | Uses bg-surface-overlay to render correctly in light/canvas themes. |
| packages/apollo-wind/src/components/ui/skeleton.test.tsx | Updates the test to assert the new Skeleton background class. |
| packages/apollo-wind/src/components/ui/dropdown-menu.tsx | Uses bg-surface-overlay for the separator for theme-correct rendering. |
| packages/apollo-wind/src/components/ui/badge.tsx | Adds status variants with new Tailwind status utility classes. |
| packages/apollo-wind/src/components/ui/badge.stories.tsx | Demonstrates the new Badge status variants in Storybook. |
187b8d2 to
953d394
Compare
CalinaCristian
approved these changes
Apr 10, 2026
953d394 to
ae8cba7
Compare
Skeleton + Dropdown item separator use surface-overlay and properly show in light theme Badge supports status variants, tailwind css updated to support status utility classes Export TooltipPortal primitive
ae8cba7 to
c1aaef5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.