Skip to content

fix(apollo-wind): address theming gaps for apollo-react/canvas [MST-8290]#487

Merged
BenGSchulz merged 1 commit intomainfrom
fix/theming-fixes
Apr 10, 2026
Merged

fix(apollo-wind): address theming gaps for apollo-react/canvas [MST-8290]#487
BenGSchulz merged 1 commit intomainfrom
fix/theming-fixes

Conversation

@BenGSchulz
Copy link
Copy Markdown
Contributor

  • Skeleton + Dropdown item separator use surface-overlay and properly show in light theme
Screenshot 2026-04-10 at 8 47 13 AM Screenshot 2026-04-10 at 8 46 50 AM
  • Badge supports status variants, tailwind css updated to support status utility classes
Screenshot 2026-04-10 at 8 45 28 AM
  • Export TooltipPortal primitive

Copilot AI review requested due to automatic review settings April 10, 2026 15:56
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-canvas 🟢 Ready Preview, Logs Apr 10, 2026, 11:11:09 AM
apollo-landing 🟢 Ready Preview, Logs Apr 10, 2026, 11:08:27 AM
apollo-ui-react 🟢 Ready Preview, Logs Apr 10, 2026, 11:10:06 AM
apollo-vertex 🟢 Ready Preview, Logs Apr 10, 2026, 11:09:32 AM
apollo-wind 🟢 Ready Preview, Logs Apr 10, 2026, 11:09:17 AM

@github-actions github-actions bot added the size:M 30-99 changed lines. label Apr 10, 2026
@github-actions
Copy link
Copy Markdown

Dependency License Review

  • 1948 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 4 package(s) excluded (see details below)
License distribution
License Packages
MIT 1707
ISC 89
Apache-2.0 61
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
Unknown 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@uipath/proteus-client 0.1.10 Unknown UiPath internal package, Proprietary license
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Apollo Wind theming gaps (notably for the canvas theme) and expands component capabilities by adding status-aware badge variants and exporting an additional Tooltip primitive.

Changes:

  • Updated Tailwind consumer theme variables/mappings to support status background utilities and improve canvas theme compatibility.
  • Switched Skeleton and DropdownMenu separator styling to use surface-overlay for better theme correctness.
  • Added Badge status variants (success/warning/error/info) and exported TooltipPortal.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/apollo-wind/src/styles/tailwind.consumer.css Adds status background variables per theme and adjusts Tailwind token mappings used to generate utilities (incl. canvas bridging).
packages/apollo-wind/src/index.ts Re-exports TooltipPortal from the tooltip module.
packages/apollo-wind/src/components/ui/tooltip.tsx Exposes Radix TooltipPrimitive.Portal as TooltipPortal.
packages/apollo-wind/src/components/ui/skeleton.tsx Uses bg-surface-overlay to render correctly in light/canvas themes.
packages/apollo-wind/src/components/ui/skeleton.test.tsx Updates the test to assert the new Skeleton background class.
packages/apollo-wind/src/components/ui/dropdown-menu.tsx Uses bg-surface-overlay for the separator for theme-correct rendering.
packages/apollo-wind/src/components/ui/badge.tsx Adds status variants with new Tailwind status utility classes.
packages/apollo-wind/src/components/ui/badge.stories.tsx Demonstrates the new Badge status variants in Storybook.

Copilot AI review requested due to automatic review settings April 10, 2026 17:53
@github-actions github-actions bot added size:L 100-499 changed lines. and removed size:M 30-99 changed lines. labels Apr 10, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Skeleton + Dropdown item separator use surface-overlay and properly show in light theme

Badge supports status variants, tailwind css updated to support status utility classes

Export TooltipPortal primitive
@BenGSchulz BenGSchulz merged commit b5903c4 into main Apr 10, 2026
38 checks passed
@BenGSchulz BenGSchulz deleted the fix/theming-fixes branch April 10, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants