chore(apollo-vertex): lint for manual memoization with React Compiler#485
Merged
chore(apollo-vertex): lint for manual memoization with React Compiler#485
Conversation
Add oxlint no-restricted-imports rule to ban useMemo, useCallback, and memo from react — the React Compiler handles memoization automatically. Remove the equivalent but unenforced Biome linter rule, and fix existing usages in icon-grid and feature-flag-demo.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
frankkluijtmans
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
no-restricted-importsrule banninguseMemo,useCallback, andmemofromreact— the React Compiler handles memoization automaticallybiome lint)icon-grid.tsxandfeature-flag-demo.tsxby replacing manual memoization with plain expressions/functionsregistry/**files to avoid false positives fromimport * as Reactnamespace imports used by shadcn componentsTest plan
pnpm lintpasses with 0 errorspnpm buildsucceedsimport { useMemo } from "react"in app codeimport * as Reactin registry files is not flagged