feat(apollo-vertex): migrate sidebar and shell to match MRS patterns#468
Open
creilly11235 wants to merge 2 commits intomainfrom
Open
feat(apollo-vertex): migrate sidebar and shell to match MRS patterns#468creilly11235 wants to merge 2 commits intomainfrom
creilly11235 wants to merge 2 commits intomainfrom
Conversation
creilly11235
requested review from
alincadariu and
pieman1313
and removed request for
a team
creilly11235
force-pushed
the
creilly11235/vertex-sidebar-registry
branch
2 times, most recently
from
ef30814 to
14d60ab
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
pieman1313
requested changes
Apr 8, 2026
creilly11235
force-pushed
the
creilly11235/vertex-sidebar-registry
branch
3 times, most recently
from
458d7c4 to
7bf3f7b
Compare
pieman1313
requested changes
Apr 9, 2026
Contributor
pieman1313
left a comment
pieman1313
left a comment
There was a problem hiding this comment.
found a bug that the user part is offscreen and can't be scrolled to, it can be accessed only by tabbing
NOTE: after addressing issues / conversations, please re-request reviews so we get notifications 😁 , its this button
creilly11235
force-pushed
the
creilly11235/vertex-sidebar-registry
branch
from
f6c00ae to
55a8eca
Compare
ruudandriessen
force-pushed
the
creilly11235/vertex-sidebar-registry
branch
from
55a8eca to
a47f03b
Compare
Align sidebar registry primitives and shell components with the vertical-medical-mrs implementation: absolute positioning, consistent collapsed width, duration-300 transitions, proper company component layout, and dynamic import for the sidebar example template. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ns and self-contained CSS Convert sidebar width animation from CSS transitions to framer-motion spring physics matching MRS exactly. Make shell components self-contained by moving collapsible CSS to co-located file, swap hand-rolled buttons for vertex Button component, add asymmetric text fade variants via AnimatePresence, fix z-index stacking in docs preview, fix minimal header logo background, and switch locale loading state from spinner to skeleton. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
creilly11235
force-pushed
the
creilly11235/vertex-sidebar-registry
branch
from
a47f03b to
f7f13af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initial={false}for SSR hydration)variant="sidebar"matching MRSTooltipProviderto minimal user profile, restore offcanvas CSS transitionTest plan
🤖 Generated with Claude Code