Fixed segmentation fault while running stereo KITTI example#876
Open
Muhammad0312 wants to merge 4 commits intoUZ-SLAMLab:masterfrom
Open
Fixed segmentation fault while running stereo KITTI example#876Muhammad0312 wants to merge 4 commits intoUZ-SLAMLab:masterfrom
Muhammad0312 wants to merge 4 commits intoUZ-SLAMLab:masterfrom
Conversation
Muhammad0312
changed the title
|
Disclaimer: I don't intend to create spam. If the ORB_SLAM3 developers wish me to stop posting, I will cease immediately. ORB_SLAM3 seems to be inactive, but there are a number of community patches, including yours, which provide important bugfixes or improvements. Therefore I have created a new project ORB_SLAM_COMMUNITY (https://github.com/jeremysalwen/ORB_SLAM_COMMUNITY) to gather together these improvements and continue active development. I have already merged this PR in the ORB_SLAM_COMMUNITY version. We would welcome any other contributions you might have. |
|
It works. Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running stereo example, it resulted in a segmentation fault.
Problem:
When
cameraType_is specified asRECTIFIEDoriginalCalib2_object is not created in theSettings::readCamera2method, but in the operator overloadoperator<<it prints these settings to the terminal which results in segmentation fault.Solution:
Added a conditional to not print the settings for second camera if
RECTIFIEDis specified.