Skip to content

feature/botmoderation#296

Merged
lunazeta merged 5 commits intomasterfrom
feature/botmoderation
Mar 19, 2026
Merged

feature/botmoderation#296
lunazeta merged 5 commits intomasterfrom
feature/botmoderation

Conversation

@lunazeta
Copy link
Copy Markdown
Contributor

As above

@lunazeta lunazeta requested a review from Tomoli75 March 19, 2026 12:50
Tomoli75
Tomoli75 previously approved these changes Mar 19, 2026
Copy link
Copy Markdown
Contributor

@Tomoli75 Tomoli75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would change the channel config key to something related to spam bots, as otherwise could be confused with storing deleted messages - lgtm otherwise

@lunazeta lunazeta requested a review from Tomoli75 March 19, 2026 13:10
Copy link
Copy Markdown
Contributor

@Tomoli75 Tomoli75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lunazeta lunazeta merged commit b8d8df6 into master Mar 19, 2026
5 checks passed
@lunazeta lunazeta deleted the feature/botmoderation branch March 19, 2026 13:12
@Cog.listener()
async def on_message(self, message: discord.Message):
joined_recently = message.author.joined_at > datetime.now() - timedelta(days=7)
contains_everyone = '@everyone' in message.content
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the text in the message for an @ everyone actually come out as @ everyone? I know pings of roles/people are <@12356789>?

Copy link
Copy Markdown
Contributor Author

@lunazeta lunazeta Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it does, as if they don't have the permission it just formats to @ everyone, in terms of actual @ everyone pings, it does the same

)

await message.delete()
await channel.send(f'<@&{CONFIG.UWCS_EXEC_ROLE_IDS[1]}>', embed=embed)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why take the 2nd role? That feels unintuitive at best - create a separate config param if you want it to be a specific role (that isn't just exec)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't know? ask whoever put the exec role as the second role in the list...

from config import CONFIG


class Database(Cog):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the cog called database?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuck, that's actually my bad

@lunazeta lunazeta restored the feature/botmoderation branch March 19, 2026 13:34
lunazeta added a commit that referenced this pull request Mar 19, 2026
lunazeta added a commit that referenced this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants