Skip to content

Sync RGB-Tools rust-lightning - #35

Open
dcorral wants to merge 13 commits into
UTEXO-Protocol:devfrom
dcorral:chore/merge-rgb-tools-rgb
Open

Sync RGB-Tools rust-lightning #35
dcorral wants to merge 13 commits into
UTEXO-Protocol:devfrom
dcorral:chore/merge-rgb-tools-rgb

Conversation

@dcorral

@dcorral dcorral commented Aug 21, 2026

Copy link
Copy Markdown

Divergences

Area Decision
Electrum unindexed output lookup (e2a0b8e24) Took upstream, replaced the fork's version. The fork tested only is_op_return() and fell back to tx.output.first() when every output was unindexed, which is the same empty history bug it was meant to fix. Upstream also excludes OP_FALSE OP_RETURN, falls back to an input's previous output, and skips the tx instead of failing the whole sync round.
watched_txs.push position Took upstream. Moved inside the if let Some(spk) block so debug_assert_eq!(num_tx_lookups, watched_txs.len()) holds when a tx is skipped.
rgb-lib dependency (66884165e) Kept the fork's source, took upstream's feature shape. default-features = false with indexer features forwarded through the crate's own electrum / esplora. The git URL and revision were not allowed to revert to an RGB-Tools or crates.io source.
rgb-lib pin location Pinned in both lightning/Cargo.toml and lightning-invoice/Cargo.toml, currently dcorral/rgb-lib rev 94b6221. Must move to a UTEXO tag (beta.34+) together with the two pins in rgb-lightning-node, or cargo fails resolution.

Breaking changes

RgbInfo gained counterparty_knows_asset; TransferInfo gained output_map. Both are persisted via bincode, which is positional and not self describing, so pre merge records are undecodable. Accepted deliberately.

66884165e is not inert plumbing: it adds a compile_error! to lightning/src/rgb_utils/mod.rs gated on lightning's own features, so any consumer must enable at least one of electrum / esplora on its lightning dependency. rgb-lightning-node#151 carries that manifest change.

Follow ups

  • is_channel_rgb swallows a deserialize error and returns false, silently reclassifying a coloured channel as vanilla.

@dcorral dcorral changed the title Sync RGB-Tools rust-lightning through e2a0b8e24 Sync RGB-Tools rust-lightning Aug 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants