Sync RGB-Tools rust-lightning - #35
Open
dcorral wants to merge 13 commits into
Open
Conversation
…ment HTLC write)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Divergences
e2a0b8e24)is_op_return()and fell back totx.output.first()when every output was unindexed, which is the same empty history bug it was meant to fix. Upstream also excludesOP_FALSE OP_RETURN, falls back to an input's previous output, and skips the tx instead of failing the whole sync round.watched_txs.pushpositionif let Some(spk)block sodebug_assert_eq!(num_tx_lookups, watched_txs.len())holds when a tx is skipped.66884165e)default-features = falsewith indexer features forwarded through the crate's ownelectrum/esplora. The git URL and revision were not allowed to revert to an RGB-Tools or crates.io source.lightning/Cargo.tomlandlightning-invoice/Cargo.toml, currentlydcorral/rgb-librev94b6221. Must move to a UTEXO tag (beta.34+) together with the two pins in rgb-lightning-node, or cargo fails resolution.Breaking changes
RgbInfogainedcounterparty_knows_asset;TransferInfogainedoutput_map. Both are persisted via bincode, which is positional and not self describing, so pre merge records are undecodable. Accepted deliberately.66884165eis not inert plumbing: it adds acompile_error!tolightning/src/rgb_utils/mod.rsgated onlightning's own features, so any consumer must enable at least one ofelectrum/esploraon itslightningdependency. rgb-lightning-node#151 carries that manifest change.Follow ups
is_channel_rgbswallows a deserialize error and returnsfalse, silently reclassifying a coloured channel as vanilla.