Skip to content

Refine review workflow stage gating, notifications, and edge cases#123

Merged
AdamGohs merged 1 commit into
mainfrom
fix/review-workflow-optimization
May 21, 2026
Merged

Refine review workflow stage gating, notifications, and edge cases#123
AdamGohs merged 1 commit into
mainfrom
fix/review-workflow-optimization

Conversation

@AdamGohs
Copy link
Copy Markdown
Collaborator

Summary

  • Reduce notification spam: only ping reviewers who have actually submitted a review when commits land; post team-request guidance only once per PR
  • Close gating gaps: handle changes_requested and dismissed review events; flip the merge gate back to pending on post-approval pushes (admin re-enables via new admin:approve-merge-after-push label); add assign:<stage> labels to pre-pin reviewer assignments to later stages
  • Polish: soften "Could not determine review lane" tone; trim verbose transition comments to reference the Documentation Guide instead of inlining numbered step lists

- Suppress backcheck pings to reviewers who haven't reviewed yet
- Handle changes_requested and dismissed review events
- Flip merge gate to pending on post-approval pushes (admin:approve-merge-after-push to re-enable)
- Add assign:<stage> labels to pre-pin reviewer assignments to later stages
- Post one-time guidance on team review requests
- Soften lane-detection failure tone
- Trim verbose transition comments; reference Documentation Guide instead
@AdamGohs AdamGohs requested a review from a team as a code owner May 21, 2026 12:44
@github-actions
Copy link
Copy Markdown

CI build passed for commit 91b6436

This PR does not touch documentation content under docs/, so no multi-stage review is required.

@usace-rmc/docs-admin may merge.

@AdamGohs AdamGohs merged commit 6a235d3 into main May 21, 2026
4 checks passed
@AdamGohs AdamGohs deleted the fix/review-workflow-optimization branch May 21, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant