Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
ad1e4f6
Add reviewer-workflow rewrite plan and capture tooling scaffold
AdamGohs May 20, 2026
84bfadb
Record sandbox PR #121 in reviewer-workflow rewrite plan
AdamGohs May 20, 2026
bc918ca
Scope Playwright install to scripts/capture so the login script resolves
AdamGohs May 20, 2026
2b41607
Make login script try real Chrome/Edge before bundled Chromium
AdamGohs May 20, 2026
63ef8fb
Attach Playwright to a real Chrome subprocess via CDP for the login flow
AdamGohs May 20, 2026
2d61bd5
Prefer Edge over Chrome in the login script's browser auto-detect
AdamGohs May 20, 2026
aa868fa
Add scripts/capture/verify-auth.mjs sanity check for saved session
AdamGohs May 20, 2026
80a46aa
Capture and annotate batch 1: PR overview, commits, files changed
AdamGohs May 20, 2026
c958f2c
Fix fig-04: dismiss popover at capture, correct All commits position
AdamGohs May 20, 2026
73acd90
Batch 2 (partial): finish-review dialog figure + preview page capture
AdamGohs May 20, 2026
b28faa3
Emit editable .pptx alongside every figure; add composer storyboard
AdamGohs May 20, 2026
8a2ff1d
Re-capture pr-files-changed from filtered URL (content commit only)
AdamGohs May 20, 2026
fbd8bb4
Remove _check.png diagnostic accidentally included in prior commit
AdamGohs May 20, 2026
06f202a
Add Section 1 Mermaid draft, bot-comments figure, two storyboard GIFs
AdamGohs May 20, 2026
f7fa3ed
Add Section 4 preview-page figure
AdamGohs May 20, 2026
2a8f11f
Capture and annotate post-submit review state (Section 8)
AdamGohs May 20, 2026
5e19859
Add 'Resume from here' section to the planning doc
AdamGohs May 20, 2026
46cdce4
Rework Reviewer Workflow as a screenshot-driven walkthrough
AdamGohs May 21, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ src/data/
.claude/mcp.json
.mcp.json
.playwright-mcp/
.playwright-auth/

# Skill review output (screenshots ignored, reports tracked)
review-output/
Expand Down
4 changes: 4 additions & 0 deletions docs/dev/documentation-guide/11-author-workflow.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ Within a minute or two of opening the PR, three bot comments appear:
2. A stage progression comment identifying the lane and what review is needed next
3. A hidden state comment that renders as an "Assigned reviewers for this PR" block, tracking which individuals the site administrator has assigned to each review stage

For the reviewer's view of these same three bot comments — and the rest of the page a reviewer lands on — see [Reviewer Workflow](./12-reviewer-workflow.mdx).

## Responding to review comments

Reviewers post comments on specific lines in the Files changed tab. For each comment, the author makes the fix, pushes a commit, and replies explaining what was done. The reviewer resolves the thread when satisfied.
Expand All @@ -64,6 +66,8 @@ For suggested changes (pre-filled code blocks), the author can click **Commit su

**All comment threads must be resolved before the PR can merge.**

Authors writing clear, descriptive commit messages make a reviewer's life much easier — see [Reviewer Workflow §3 — Navigating commits within a PR](./12-reviewer-workflow.mdx#navigating-commits-within-a-pr) for how a reviewer uses your commit messages to focus their attention.

## The technical edit (Lanes 1, 2, and 3)

After the previous review stage approves the PR, the technical edit stage begins. A team member triggers an AI-assisted technical edit against the PR. The AI reads the source MDX files directly and posts inline review comments covering grammar, tense, clarity, terminology, and Section 508 accessibility. The document is not yet deployed to the live site at this stage — the technical edit works on source files, so the live deploy is deferred until the technical edit is complete.
Expand Down
483 changes: 446 additions & 37 deletions docs/dev/documentation-guide/12-reviewer-workflow.mdx

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions docs/dev/documentation-guide/15-site-admin-workflow.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ Reviewers are assigned ad-hoc per PR via the Reviewers sidebar (gear icon → ty

For Lane 1, the site administrator assigns up to three people across the lifecycle: the peer reviewer (if the author did not), the Lead Civil after peer approval, and the Director after the technical edit.

For what the assigned reviewer experiences from the email notification through submitting their review, see [Reviewer Workflow](./12-reviewer-workflow.mdx). This is especially useful context when onboarding a first-time reviewer.

**Per-individual gating.** When the site administrator assigns someone via the Reviewers sidebar, the stage progression workflow records that person in a hidden state comment on the PR, keyed by the current review stage. Only approvals from those assigned reviewers advance the stage — drive-by approvals from other team members are logged but ignored by the workflow. Multiple people can be assigned at the same stage; the first approval from any of them advances the PR.

To replace an assigned reviewer, the site administrator removes them from the Reviewers sidebar and adds the correct person. The state comment updates automatically.
Expand Down
Loading
Loading