Fix EAC-CPF namespace handling in XPath queries#9
Merged
alexdryden merged 3 commits intoindex_creatorsfrom Feb 11, 2026
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses namespace inconsistency in
traject_config_eac_cpf.rbwhere XPath queries mixed prefixed and unprefixed element names. Since EAC-CPF documents use a default namespace (xmlns="urn:isbn:1-931666-33-4"), unprefixed XPath queries fail to match elements.Changes
EAC_NS = { 'eac' => 'urn:isbn:1-931666-33-4' }eac:prefix consistently across all 24 queriesBefore:
After:
This ensures reliable extraction from ArchivesSpace EAC-CPF exports.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.