Skip to content

[Investigation] Verify xlink:href attribute access in Nokogiri - NOT NEEDED #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

[Investigation] Verify xlink:href attribute access in Nokogiri - NOT NEEDED #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0aa46f8
Initial plan
Copilot Feb 13, 2026
fb7b94a
Fix namespaced xlink:href attribute access in Nokogiri
Copilot Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions traject_config_eac_cpf.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@
relations = record.xpath('//eac:cpfDescription/eac:relations/eac:cpfRelation', EAC_NS)
relations.each do |rel|
# Get the related entity href/identifier
href = rel['href'] || rel['xlink:href']
href = rel['href'] || rel.attribute_with_ns('href', 'http://www.w3.org/1999/xlink')&.value
relation_type = rel['cpfRelationType']

if href
Expand All @@ -233,7 +233,7 @@
to_field 'related_agent_uris_ssim' do |record, accumulator|
relations = record.xpath('//eac:cpfDescription/eac:relations/eac:cpfRelation', EAC_NS)
relations.each do |rel|
href = rel['href'] || rel['xlink:href']
href = rel['href'] || rel.attribute_with_ns('href', 'http://www.w3.org/1999/xlink')&.value
accumulator << href if href
end
end
Expand Down