fix(ui5-list): suppress F2 aria description for custom items without tabbables#13865
Open
kgogov wants to merge 1 commit into
Open
fix(ui5-list): suppress F2 aria description for custom items without tabbables#13865kgogov wants to merge 1 commit into
kgogov wants to merge 1 commit into
Conversation
…tabbables Previously the "To move to the content, press F2" hint was announced for every ui5-li-custom, on the assumption that custom items may host arbitrary tabbable slot content. In the very common case where ui5-li-custom is used purely for visual richness (icon + description + additional text), the hint was misleading - F2 has nowhere to go, so pressing it does nothing. Replace the type-based check in _hasInteractiveItems with a behavioural call to _hasFocusableElements(), so the announcement matches what F2 actually does. Related to: #13489 Fixes: #13713
|
🚀 Deployed on https://pr-13865--ui5-webcomponents-preview.netlify.app |
Contributor
Author
|
Quick before/after for reviewers 👀 Same playground fragment (customer's exact repro from #13713), rendered against
How to inspect: open DevTools → find |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the "To move to the content, press F2" hint was announced for every
ui5-li-custom, on the assumption that custom items may host arbitrary tabbable slot content. In the very common case whereui5-li-customis used purely for visual richness (icon + description + additional text), the hint was misleading - F2 has nowhere to go, so pressing it does nothing.Replace the type-based check in
_hasInteractiveItemswith a behavioural call to_hasFocusableElements(), so the announcement matches what F2 actually does.Related to: #13489
Fixes: #13713