Skip to content

test: reproduce rare tokenizer loop #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vonahz wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −19
Open

test: reproduce rare tokenizer loop #13862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/Tokenizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
import TokenizerTemplate from "./TokenizerTemplate.js";
import type Button from "./Button.js";
import {
MULTIINPUT_SHOW_MORE_TOKENS,

Check failure on line 63 in packages/main/src/Tokenizer.ts

View workflow job for this annotation

GitHub Actions / check 

'MULTIINPUT_SHOW_MORE_TOKENS' is defined but never used
TOKENIZER_ARIA_LABEL,
TOKENIZER_ARIA_CONTAIN_TOKEN,
TOKENIZER_ARIA_CONTAIN_ONE_TOKEN,
Expand Down Expand Up @@ -1214,7 +1214,7 @@
}

if (this._getVisibleTokens().length) {
return Tokenizer.i18nBundle.getText(MULTIINPUT_SHOW_MORE_TOKENS, this._nMoreCount);
return Tokenizer.i18nBundle.getText("{0} moree", this._nMoreCount);
}

return Tokenizer.i18nBundle.getText(TOKENIZER_SHOW_ALL_ITEMS, this._nMoreCount);
Expand Down
8 changes: 4 additions & 4 deletions packages/main/test/pages/MultiComboBox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,12 @@
<span>Predefined value</span>

<br>
<ui5-multi-combobox no-validation id="multi1" accessible-name="MultiComboBox with predefined values">
<ui5-mcb-item selected text="Longest word in the whole universe"></ui5-mcb-item>
<ui5-multi-combobox no-validation id="multi1" accessible-name="MultiComboBox with predefined values" style="width:205px">
<ui5-mcb-item selected text="asd"></ui5-mcb-item>
<ui5-mcb-item selected text="Cosy"></ui5-mcb-item>
<ui5-mcb-item text="Compact"></ui5-mcb-item>
<ui5-mcb-item selected text="Condensed"></ui5-mcb-item>
<ui5-mcb-item selected text="Longest word in the world"></ui5-mcb-item>
<ui5-mcb-item text="Condensed"></ui5-mcb-item>
<ui5-mcb-item text="Longest word in the world"></ui5-mcb-item>
</ui5-multi-combobox>
<br>
<br>
Expand Down
15 changes: 4 additions & 11 deletions packages/main/test/pages/MultiInput.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,18 +62,11 @@ <h1 class="sample-container-title">Readonly Multi Input with tokens</h1>
<br>

<h1 class="sample-container-title">Multi Input with 11 tokens (overflowing)</h1>
<ui5-multi-input id="basic-overflow">
<ui5-multi-input id="basic-overflow" style="width: 155px;">
<ui5-token slot="tokens" text="Amet"></ui5-token>
<ui5-token slot="tokens" text="Incididunt"></ui5-token>
<ui5-token slot="tokens" text="laboris"></ui5-token>
<ui5-token slot="tokens" text="ea"></ui5-token>
<ui5-token slot="tokens" text="eu"></ui5-token>
<ui5-token slot="tokens" text="ipsum"></ui5-token>
<ui5-token slot="tokens" text="do"></ui5-token>
<ui5-token slot="tokens" text="esse"></ui5-token>
<ui5-token slot="tokens" text="eu"></ui5-token>
<ui5-token slot="tokens" text="amet"></ui5-token>
<ui5-token slot="tokens" text="do"></ui5-token>
<ui5-token slot="tokens" text="Incididunt dass sdsa sd "></ui5-token>
<!-- <ui5-token slot="tokens" text="laboris"></ui5-token> -->
<!-- <ui5-token slot="tokens" text="ea"></ui5-token> -->
</ui5-multi-input>

<br>
Expand Down
5 changes: 2 additions & 3 deletions packages/main/test/pages/Tokenizer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,10 @@ <h1 class="sample-container-title">Expanded tokenizer</h1>
</div>
<h1 class="sample-container-title">Only nItems tokenizer</h1>
<ui5-label id="n-items-label">Tokenizer with 2 items</ui5-label>
<ui5-tokenizer id="basic-tokenizer" accessible-name-ref="n-items-label">
<ui5-token text="Your name and email address were configured automatically based
on your username and hostname. Please check that they are accurate."></ui5-token>
<ui5-tokenizer id="basic-tokenizer" accessible-name-ref="n-items-label" style="width: 117px;">
<ui5-token text="Your name and email address were configured automatically based
on your username and hostname. Please check that they are accurate."></ui5-token>
<ui5-token text="Acc."></ui5-token>
</ui5-tokenizer>

<h1 class="sample-container-title">Tokenizer with n-more items</h1>
Expand Down
Loading