Skip to content

fix(ui5-calendar): format aria-label day cell value#13838

Open
GDamyanov wants to merge 11 commits into
mainfrom
calendar-aria-label-format
Open

fix(ui5-calendar): format aria-label day cell value#13838
GDamyanov wants to merge 11 commits into
mainfrom
calendar-aria-label-format

Conversation

@GDamyanov

Copy link
Copy Markdown
Contributor

Currently the format of the date in day cells aria-label attributes was hardcoded, now it is formatted according to the current locale.

Fixes: #13594

@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 17, 2026 08:32 — with GitHub Actions Inactive
@GDamyanov
GDamyanov marked this pull request as ready for review July 17, 2026 08:32
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 17, 2026 08:36 — with GitHub Actions Inactive
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@GDamyanov
GDamyanov requested review from Todor-ads and unazko July 20, 2026 07:12
Comment thread packages/main/cypress/specs/Calendar.cy.tsx Outdated
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 21, 2026 07:49 — with GitHub Actions Inactive
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 21, 2026 08:56 — with GitHub Actions Inactive
@GDamyanov
GDamyanov requested a review from unazko July 21, 2026 08:57
unazko
unazko previously approved these changes Jul 21, 2026

@unazko unazko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 22, 2026 10:55 — with GitHub Actions Inactive
Todor-ads
Todor-ads previously approved these changes Jul 23, 2026
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 23, 2026 07:43 — with GitHub Actions Inactive
@GDamyanov
GDamyanov dismissed stale reviews from Todor-ads and unazko via 5b8e112 July 23, 2026 08:37
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 23, 2026 08:46 — with GitHub Actions Inactive
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 23, 2026 12:16 — with GitHub Actions Inactive
@GDamyanov
GDamyanov requested review from Todor-ads and unazko July 23, 2026 13:25
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 23, 2026 13:30 — with GitHub Actions Inactive
@GDamyanov
GDamyanov temporarily deployed to netlify-preview July 24, 2026 12:21 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DatePicker]: aria-label format issue for dates

3 participants