Skip to content

feat(ui5-product-switch): support 2-column layout and free text wrapping#13819

Open
IlianaB wants to merge 3 commits into
mainfrom
fix-product-switch-two-column-wrapping
Open

feat(ui5-product-switch): support 2-column layout and free text wrapping#13819
IlianaB wants to merge 3 commits into
mainfrom
fix-product-switch-two-column-wrapping

Conversation

@IlianaB

@IlianaB IlianaB commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Add a 2-column desktop layout for cases with two or fewer items, since the previous logic only supported 3 or 4 columns. The ProductSwitch now sets desktop-columns="2" (376px width) accordingly.

Enable free text wrapping for the item title and subtitle instead of truncating with an ellipsis. Per the updated design spec, text is never truncated - it wraps freely and the item grows vertically, with items in the same row stretching to match the tallest one.

JIRA: BGSOFUIPIRIN-6851

Add a 2-column desktop layout for cases with two or fewer items, since
the previous logic only supported 3 or 4 columns. The ProductSwitch now
sets desktop-columns="2" (376px width) accordingly.

Enable free text wrapping for the item title and subtitle instead of
truncating with an ellipsis. Per the updated design spec, text is never
truncated - it wraps freely and the item grows vertically, with items in
the same row stretching to match the tallest one.
@IlianaB
IlianaB temporarily deployed to netlify-preview July 13, 2026 13:19 — with GitHub Actions Inactive
@sap-ui5-webcomponents-release

Copy link
Copy Markdown

@IlianaB
IlianaB temporarily deployed to netlify-preview July 14, 2026 11:53 — with GitHub Actions Inactive
@IlianaB
IlianaB temporarily deployed to netlify-preview July 15, 2026 07:38 — with GitHub Actions Inactive
@PetyaMarkovaBogdanova
PetyaMarkovaBogdanova self-requested a review July 21, 2026 07:42
@github-actions

Copy link
Copy Markdown

👋 Heads-up: dev close is in effect

Thanks for the contribution! This repository is currently in dev close ahead of release 2.25 (scheduled 2026-07-29, UTC). See the release schedule for the full timeline.

This PR appears to introduce public-API changes (detected by diffing the Custom Elements Manifest against the latest published version on npm):

@ui5/webcomponents-fiori

  • ➕ added interface: IProductSwitchItem

Could you please hold off on merging into main until the release ships? Public-API changes are best landed in the next dev cycle so they don't slip into the release at the last minute. Once the release is out, this PR is good to go.

If this change must ship in the current release, please request a review from one or two members of @UI5/ui5-team-webc so the team can sign off explicitly.

💬 False positive? If you believe this PR doesn't actually change the public API (e.g. only internal refactoring, or an entry the detector mis-attributed), please reply on this thread — your feedback helps us improve the detection during this trial run.

Posted automatically by the Dev Close Notice workflow.

@PetyaMarkovaBogdanova PetyaMarkovaBogdanova left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a well-implemented feature that:

✅ Solves the long-text readability problem through wrapping instead of truncation
✅ Adds 2-column layout support for 1-2 item scenarios
✅ Maintains all existing functionality for 3+ items
✅ Includes robust test coverage validating behavior across all scenarios
✅ Follows project conventions and accessibility best practices
✅ Supports responsive design from desktop to mobile
All requirements met with excellent test coverage and design spec alignment.

Although I would recommend using overflow-wrap: break-word instead of "everywhere" for readability, if there aren't specific reason we use it as it is.
And would ask you to update the samples with concrete wrapping example.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants