feat(ui5-product-switch): support 2-column layout and free text wrapping#13819
feat(ui5-product-switch): support 2-column layout and free text wrapping#13819IlianaB wants to merge 3 commits into
Conversation
Add a 2-column desktop layout for cases with two or fewer items, since the previous logic only supported 3 or 4 columns. The ProductSwitch now sets desktop-columns="2" (376px width) accordingly. Enable free text wrapping for the item title and subtitle instead of truncating with an ellipsis. Per the updated design spec, text is never truncated - it wraps freely and the item grows vertically, with items in the same row stretching to match the tallest one.
|
🚀 Deployed on https://pr-13819--ui5-webcomponents-preview.netlify.app |
👋 Heads-up: dev close is in effectThanks for the contribution! This repository is currently in dev close ahead of release This PR appears to introduce public-API changes (detected by diffing the Custom Elements Manifest against the latest published version on npm):
Could you please hold off on merging into If this change must ship in the current release, please request a review from one or two members of @UI5/ui5-team-webc so the team can sign off explicitly.
Posted automatically by the Dev Close Notice workflow. |
PetyaMarkovaBogdanova
left a comment
There was a problem hiding this comment.
This is a well-implemented feature that:
✅ Solves the long-text readability problem through wrapping instead of truncation
✅ Adds 2-column layout support for 1-2 item scenarios
✅ Maintains all existing functionality for 3+ items
✅ Includes robust test coverage validating behavior across all scenarios
✅ Follows project conventions and accessibility best practices
✅ Supports responsive design from desktop to mobile
All requirements met with excellent test coverage and design spec alignment.
Although I would recommend using overflow-wrap: break-word instead of "everywhere" for readability, if there aren't specific reason we use it as it is.
And would ask you to update the samples with concrete wrapping example.
Thank you.
Add a 2-column desktop layout for cases with two or fewer items, since the previous logic only supported 3 or 4 columns. The ProductSwitch now sets desktop-columns="2" (376px width) accordingly.
Enable free text wrapping for the item title and subtitle instead of truncating with an ellipsis. Per the updated design spec, text is never truncated - it wraps freely and the item grows vertically, with items in the same row stretching to match the tallest one.
JIRA: BGSOFUIPIRIN-6851