test(ui5-side-navigation): re-enable and stabilize overflow menu test#13654
Open
GerganaKremenska wants to merge 2 commits into
Open
test(ui5-side-navigation): re-enable and stabilize overflow menu test#13654GerganaKremenska wants to merge 2 commits into
GerganaKremenska wants to merge 2 commits into
Conversation
Replaces unreliable visibility checks with ui5MenuOpened/ui5MenuClosed
commands, which wait for the popover transitions and focus restoration
to complete before asserting. The previous use of `should("be.visible")`
and `should("not.be.visible")` raced with the popover open/close
animations, causing intermittent failures of the focus assertion on CI.
Reverts the .skip added in #13637.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIXES: #13638