Skip to content

feat(ui5-step-input): add property which hides step buttons #13364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GDamyanov wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(ui5-step-input): add property which hides step buttons #13364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/main/src/StepInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,9 @@ class StepInput extends UI5Element implements IFormInputElement {
@property()
accessibleNameRef?: string;

@property({ type: Boolean })
hideStepButtons = false;

@property({ noAttribute: true })
_decIconDisabled = false;

Expand Down
2 changes: 2 additions & 0 deletions packages/main/src/StepInputTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ export default function StepInputTemplate(this: StepInput) {
onMouseDown={this._decSpin}
onMouseUp={this._resetSpin}
onMouseOut={this._resetSpinOut}
hidden={this.hideStepButtons}
class={{
"inputIcon": true,
"ui5-step-input-icon--clickable": this._decIconClickable,
Expand Down Expand Up @@ -86,6 +87,7 @@ export default function StepInputTemplate(this: StepInput) {
onMouseUp={this._resetSpin}
onMouseOut={this._resetSpinOut}
showTooltip={true}
hidden={this.hideStepButtons}
/>
</div>
}
Expand Down
6 changes: 6 additions & 0 deletions packages/main/test/pages/StepInput.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,12 @@ <h3>StepInput with large value and precision (thousands separator)</h3>
</ui5-step-input>
</div>

<h3> Step Input without buttons (numeric mode)</h3>
<ui5-step-input id="stepInputNumericMode"
class="stepinput2auto"
hide-step-buttons
></ui5-step-input>

<section>
<h3>Form validation</h3>
<form id="formValidation">
Expand Down
4 changes: 4 additions & 0 deletions packages/website/docs/_components_pages/main/StepInput.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ slug: ../StepInput

import Basic from "../../_samples/main/StepInput/Basic/Basic.md";
import ValuePrecision from "../../_samples/main/StepInput/ValuePrecision/ValuePrecision.md";
import Numeric from "../../_samples/main/StepInput/Numeric/Numeric.md";
import MinMax from "../../_samples/main/StepInput/MinMax/MinMax.md";
import States from "../../_samples/main/StepInput/States/States.md";

Expand All @@ -19,6 +20,9 @@ import States from "../../_samples/main/StepInput/States/States.md";
### Min Max
<MinMax />

### Numeric Mode
<Numeric/>

### Value Precision
<ValuePrecision />

Expand Down
5 changes: 5 additions & 0 deletions packages/website/docs/_samples/main/StepInput/Numeric/Numeric.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import html from '!!raw-loader!./sample.html';
import js from '!!raw-loader!./main.js';
import react from '!!raw-loader!./sample.tsx';

<Editor html={html} js={js} react={react} />
1 change: 1 addition & 0 deletions packages/website/docs/_samples/main/StepInput/Numeric/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
import "@ui5/webcomponents/dist/StepInput.js";
20 changes: 20 additions & 0 deletions packages/website/docs/_samples/main/StepInput/Numeric/sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!-- playground-fold -->
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Sample</title>
</head>
<body style="background-color: var(--sapBackgroundColor);">
<div style="width: 15rem; height: 70px">
<!-- playground-fold-end -->

<ui5-step-input value="5" min="0" max="10" step="0.5" value-precision="1" hide-step-buttons></ui5-step-input>
<!-- playground-fold -->
</div>
<script type="module" src="main.js"></script>
</body>
</html>
<!-- playground-fold-end -->

12 changes: 12 additions & 0 deletions packages/website/docs/_samples/main/StepInput/Numeric/sample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import createReactComponent from "@ui5/webcomponents-base/dist/createReactComponent.js";
import StepInputClass from "@ui5/webcomponents/dist/StepInput.js";

const StepInput = createReactComponent(StepInputClass);

function App() {
return (
<StepInput value={5} min={0} max={10} step={0.5} valuePrecision={1} hideStepButtons={true} />
);
}

export default App;
Loading