Skip to content

fix(ui5-li): remove redundant "Is Active" accessibility announcement #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plamenivanov91 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

fix(ui5-li): remove redundant "Is Active" accessibility announcement #13338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/main/cypress/specs/List.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,12 +360,13 @@ describe("List - Accessibility", () => {
</List>
);

// assert
// assert - "Is Active" should NOT be announced for type="Active"
// The type property indicates behavior (clickable), not state (selected)
cy.get("#active").invoke("prop", "_id").then(_id => {
cy.get("#active")
.shadow()
.find(`#${_id}-invisibleText`)
.should("have.text", "Is Active");
.should("not.have.text", "Is Active");
});

cy.get("#inactive").invoke("prop", "_id").then(_id => {
Expand Down
2 changes: 0 additions & 2 deletions packages/main/src/ListItem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import {
DELETE,
ARIA_LABEL_LIST_ITEM_CHECKBOX,
ARIA_LABEL_LIST_ITEM_RADIO_BUTTON,
LIST_ITEM_ACTIVE,
LIST_ITEM_SELECTED,
LIST_ITEM_NOT_SELECTED,
} from "./generated/i18n/i18n-defaults.js";
Expand Down Expand Up @@ -475,7 +474,6 @@ abstract class ListItem extends ListItemBase {
const texts = [
this._accInfo.listItemAriaLabel,
this.accessibleName,
this.typeActive ? ListItem.i18nBundle.getText(LIST_ITEM_ACTIVE) : undefined,
].filter(Boolean);

return texts.join(" ");
Expand Down
3 changes: 0 additions & 3 deletions packages/main/src/i18n/messagebundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,6 @@ LINK_EMPHASIZED=Emphasized
#XACT: ARIA announcement for the interactive nature of the list
LIST_ROLE_DESCRIPTION=List with interactive items. To move to the content press F2.

#XACT: ARIA announcement for the active clickable list items
LIST_ITEM_ACTIVE=Is Active

#XACT: ARIA announcement for the position of the list items in an entire list
LIST_ITEM_POSITION=List item {0} of {1}

Expand Down
Loading