feat(ui5-table-row): add semantic click event on TableRow#13303
Open
feat(ui5-table-row): add semantic click event on TableRow#13303
Conversation
TableRow now fires its own custom `click` event when an interactive row is activated via mouse click or Enter key. The native click is intercepted and suppressed, replaced by a CustomEvent that covers both mouse and keyboard activation — matching the established pattern used by Button, Link, Icon, and other components. This enables React consumers using `createReactComponent` to attach `onClick` handlers directly on `<TableRow>`. The existing Table-level `row-click` event is preserved for backward compatibility.
e2b5b14 to
4d181eb
Compare
Move @CustomElement decorator right after the @Class JSDoc block, and place the event JSDoc + @eventStrict after it — matching the established ordering used by Button and other components.
Collaborator
|
🚀 Deployed on https://pr-13303--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ui5-table-rownow fires its own customclickevent when an interactive row is activated via mouse click or Enter keyButton) and replaced with aCustomEventthat unifies mouse and keyboard activationrow-clickevent is preserved for backward compatibilityButton,Link,Icon,CardHeader, and other componentsThis enables React consumers using
createReactComponentto attachonClickhandlers directly on<TableRow>:Implementation details
@eventStrict("click", { bubbles: true })declared onTableRoweventDetails.clickdeclared onTableRowBaseto maintain JSX type compatibility across the hierarchy (same pattern asSideNavigationItemBase)stopImmediatePropagationin a constructor-registered listener, then forwarded to the Table's event router soTableNavigationand other extensions still work_handleClick()firesfireDecoratorEvent("click")followed by_table._onRowClick()for backward compatTest plan
row-clicktest still passesTableSelections.cy.tsx) all pass — RowOnly behavior unaffected