test(server): Speed up reinitializeMissingDependency via shortened poll - #1524
Merged
Conversation
The test sat through the real 30 s slow-recovery interval, taking 35 s+. Expose the interval through a test-only __internals__ handle on the Supervisor (NODE_ENV-gated, undefined in production) so the test can shorten it to 500 ms. Rework the fast-budget drain to count re-resolve failures instead of detecting a quiet window, since a slow interval near the fast cadence no longer distinguishes the two phases by timing. The test now runs in ~6 s and still drives the genuine end-to-end recovery path.
RandomByte
approved these changes
Aug 14, 2026
Member
Author
|
There is still a flaky test for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test sat through the real 30 s slow-recovery interval, taking 35 s+. Expose the interval through a test-only internals handle on the Supervisor (NODE_ENV-gated, undefined in production) so the test can shorten it to 500 ms.
Rework the fast-budget drain to count re-resolve failures instead of detecting a quiet window, since a slow interval near the fast cadence no longer distinguishes the two phases by timing. The test now runs in ~6 s and still drives the genuine end-to-end recovery path.