Skip to content

deps!: Require Node.js ^22.22.2 || ^24.15.0 || >=26.0.0 - #1522

Merged
maxreichmann merged 1 commit into
mainfrom
node-engine/22.20.0-22.22.2
Aug 14, 2026
Merged

deps!: Require Node.js ^22.22.2 || ^24.15.0 || >=26.0.0#1522
maxreichmann merged 1 commit into
mainfrom
node-engine/22.20.0-22.22.2

Conversation

@maxreichmann

@maxreichmann maxreichmann commented Aug 13, 2026

Copy link
Copy Markdown
Member

This bumps the project's node engine requirements:
--> from ^22.20.0 || >=24.0.0
--> to ^22.22.2 || ^24.15.0 || >=26.0.0

Alignes with requirements used in @npmcli packages and npm 12.
Solves engine conflict in #1494.
Adds new node version (26) to CI test matrix.
Updates documentation.

@maxreichmann
maxreichmann force-pushed the node-engine/22.20.0-22.22.2 branch from d31cfca to b9ee59f Compare August 13, 2026 08:43
@maxreichmann
maxreichmann marked this pull request as ready for review August 13, 2026 08:57
@maxreichmann
maxreichmann requested a review from a team August 13, 2026 08:57

@matz3 matz3 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two remarks:

  • Should we also bump the v24 requirement, as we now require a v22 version from March 2026, but still allow the initial v24 release from May 2025? To me this does not fit right now, and the v22 version might contain more features (back-ports), than the v24. Also, looking at #1494 (comment) it was stated that the @npmcli/config package needs ^22.22.2 || ^24.15.0. But actually it needs ^22.22.2 || ^24.15.0 || >=26.0.0 (based on version 11.0.1)
  • Should we rather declare this as a breaking change, to make our requirement changes clear in the next alpha release notes?

Comment thread internal/documentation/docs/pages/GettingStarted.md Outdated
@matz3

matz3 commented Aug 13, 2026

Copy link
Copy Markdown
Member

Third remark:

Do you know why the CI does not fail? I would have expected that the check via #1360 catches that.
EDIT: Nevermind. The dependency doesn't get updated in this PR, so it would only fail there. All good here, no CI issue.

@flovogt

flovogt commented Aug 13, 2026

Copy link
Copy Markdown
Member

Should we also bump the v24 requirement, as we now require a v22 version from March 2026, but still allow the initial v24 release from May 2025? To me this does not fit right now, and the v22 version might contain more features (back-ports), than the v24. Also, looking at #1494 (comment) it was stated that the @npmcli/config package needs ^22.22.2 || ^24.15.0. But actually it needs ^22.22.2 || ^24.15.0 || >=26.0.0 (based on version 11.0.1)

I agree. Let set the version to ^22.22.2 || ^24.15.0 || >=26.0.0 for now

Should we rather declare this as a breaking change, to make our requirement changes clear in the next alpha release notes?

As we are still in the alpha phase every new release might be breaking. As we edit the changelog for initial v5 later anyway, I guess its fine to mark this as breaking

@matz3

matz3 commented Aug 13, 2026

Copy link
Copy Markdown
Member

As we are still in the alpha phase every new release might be breaking. As we edit the changelog for initial v5 later anyway, I guess its fine to mark this as breaking

Yes, we need to state the breaking changes compared to v4 in the final v5.0.0 release. I agree that we should add this breaking change to inform front-runners who want to test our pre-releases.

EDIT: Sorry, I first misunderstood your point.

@maxreichmann maxreichmann changed the title refactor: Set project node version to 22.22.2 refactor: Set project node version to ^22.22.2 || ^24.15.0 || >=26.0.0 Aug 13, 2026
@maxreichmann
maxreichmann force-pushed the node-engine/22.20.0-22.22.2 branch from 3d4ef59 to 5cfbe55 Compare August 13, 2026 12:34
@maxreichmann

Copy link
Copy Markdown
Member Author

Update:

  • Set node version requirements to: ^22.22.2 || ^24.15.0 || >=26.0.0
  • Add node 26 to CI test matrix (@UI5/ui5-team-cor-fnd ?)

@maxreichmann maxreichmann changed the title refactor: Set project node version to ^22.22.2 || ^24.15.0 || >=26.0.0 dep!: Set project node version to ^22.22.2 || ^24.15.0 || >=26.0.0 Aug 13, 2026
Comment thread package-lock.json Outdated
@maxreichmann
maxreichmann force-pushed the node-engine/22.20.0-22.22.2 branch 3 times, most recently from 55b2646 to cb9166a Compare August 13, 2026 13:52
@maxreichmann
maxreichmann requested a review from a team August 14, 2026 09:16
@matz3

matz3 commented Aug 14, 2026

Copy link
Copy Markdown
Member

dep is not a valid type (I assume you meant deps). Please also adjust the commit(s) so that the CI can validate the commit message.
Regarding the title, I would rather expect something that makes clear that we now require those versions for our packages. The current Set project node version can sound like we are using the versions now, but it does not state that consumers need to adjust, which is the case here.
I would suggest deps!: Require Node.js ^22.22.2 || ^24.15.0 || >=26.0.0, which fits to what most other npm packages describe in their changelogs.

@maxreichmann maxreichmann changed the title dep!: Set project node version to ^22.22.2 || ^24.15.0 || >=26.0.0 deps!: Require Node.js ^22.22.2 || ^24.15.0 || >=26.0.0 Aug 14, 2026
@maxreichmann
maxreichmann force-pushed the node-engine/22.20.0-22.22.2 branch from cb9166a to 36af21e Compare August 14, 2026 10:23
@maxreichmann
maxreichmann merged commit f02105e into main Aug 14, 2026
78 checks passed
@maxreichmann
maxreichmann deleted the node-engine/22.20.0-22.22.2 branch August 14, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants