build(deps-dev): Bump ajv from 6.12.6 to 8.18.0 and ajv-errors from 1.0.1 to 3.0.0#1309
Merged
build(deps-dev): Bump ajv from 6.12.6 to 8.18.0 and ajv-errors from 1.0.1 to 3.0.0#1309
Conversation
Member
Author
|
Please, bare in mind that this will not resolve all of the recent vulnerabilities of AJV as eslint also uses a vulnerable version and it's still not patched |
0821a4a to
89ceec8
Compare
f40a738 to
69388ad
Compare
69388ad to
5082300
Compare
RandomByte
approved these changes
Mar 9, 2026
Member
RandomByte
left a comment
There was a problem hiding this comment.
Change looks good. I did some very basic performance measurements and it seems to be consistently slower than before. We should definitely document the performance impact of this change.
d3xter666
added a commit
to SAP/ui5-project
that referenced
this pull request
Mar 10, 2026
…o 3.0.0 (#860) JIRA: CPOUI5FOUNDATION-859 PoC resolution in v4: #427 v5 implementation: UI5/cli#1309 ### Performance There's a slight performance degradation after the update. This is an expected behaviour as the code behind the generated validation function has evolved. They have added more comprehensive checks in there and more verbose logging. This is clearly visible in the coverage reports that we have integrated for tha function in our test scenarios. #### Comparisson Command: `time ui5 build` ##### sap.m ###### After info ProjectBuilder Build succeeded in 18 s info ProjectBuilder Executing cleanup tasks... ui5 build 36.37s user 11.09s system 246% cpu 19.237 total ###### Before info ProjectBuilder Build succeeded in 17 s info ProjectBuilder Executing cleanup tasks... ui5 build 35.54s user 10.14s system 247% cpu 18.480 total --- ##### sap.ui.core ###### After info ProjectBuilder Build succeeded in 9.42 s info ProjectBuilder Executing cleanup tasks... ui5 build 23.09s user 5.16s system 276% cpu 10.212 total ###### Before info ProjectBuilder Build succeeded in 9.43 s info ProjectBuilder Executing cleanup tasks... ui5 build 22.54s user 5.43s system 273% cpu 10.242 total
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: CPOUI5FOUNDATION-859
PoC resolution in v4: SAP/ui5-project#427
v4 implementation: SAP/ui5-project#860
Performance
There's a slight performance degradation after the update. This is an expected behaviour as the code behind the generated validation function has evolved. They have added more comprehensive checks in there and more verbose logging. This is clearly visible in the coverage reports that we have integrated for tha function in our test scenarios.
Comparisson
Command:
time ui5 buildsap.m
After
info ProjectBuilder Build succeeded in 18 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 36.37s user 11.09s system 246% cpu 19.237 total
Before
info ProjectBuilder Build succeeded in 17 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 35.54s user 10.14s system 247% cpu 18.480 total
sap.ui.core
After
info ProjectBuilder Build succeeded in 9.42 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 23.09s user 5.16s system 276% cpu 10.212 total
Before
info ProjectBuilder Build succeeded in 9.43 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 22.54s user 5.43s system 273% cpu 10.242 total