Skip to content

build(deps-dev): Bump ajv from 6.12.6 to 8.18.0 and ajv-errors from 1.0.1 to 3.0.0#1309

Merged
d3xter666 merged 7 commits intomainfrom
deps/update-ajv
Mar 10, 2026
Merged

build(deps-dev): Bump ajv from 6.12.6 to 8.18.0 and ajv-errors from 1.0.1 to 3.0.0#1309
d3xter666 merged 7 commits intomainfrom
deps/update-ajv

Conversation

@d3xter666
Copy link
Member

@d3xter666 d3xter666 commented Feb 18, 2026

JIRA: CPOUI5FOUNDATION-859

PoC resolution in v4: SAP/ui5-project#427
v4 implementation: SAP/ui5-project#860

Performance

There's a slight performance degradation after the update. This is an expected behaviour as the code behind the generated validation function has evolved. They have added more comprehensive checks in there and more verbose logging. This is clearly visible in the coverage reports that we have integrated for tha function in our test scenarios.

Comparisson

Command: time ui5 build

sap.m
After

info ProjectBuilder Build succeeded in 18 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 36.37s user 11.09s system 246% cpu 19.237 total

Before

info ProjectBuilder Build succeeded in 17 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 35.54s user 10.14s system 247% cpu 18.480 total


sap.ui.core
After

info ProjectBuilder Build succeeded in 9.42 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 23.09s user 5.16s system 276% cpu 10.212 total

Before

info ProjectBuilder Build succeeded in 9.43 s
info ProjectBuilder Executing cleanup tasks...
ui5 build 22.54s user 5.43s system 273% cpu 10.242 total

@d3xter666
Copy link
Member Author

Please, bare in mind that this will not resolve all of the recent vulnerabilities of AJV as eslint also uses a vulnerable version and it's still not patched

@coveralls
Copy link

coveralls commented Feb 18, 2026

Coverage Status

coverage: 94.337% (+0.02%) from 94.318%
when pulling b03e8fe on deps/update-ajv
into 4e2d690 on main.

Copy link
Member

@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. I did some very basic performance measurements and it seems to be consistently slower than before. We should definitely document the performance impact of this change.

@d3xter666 d3xter666 merged commit b82209e into main Mar 10, 2026
30 checks passed
@d3xter666 d3xter666 deleted the deps/update-ajv branch March 10, 2026 09:58
d3xter666 added a commit to SAP/ui5-project that referenced this pull request Mar 10, 2026
…o 3.0.0 (#860)

JIRA: CPOUI5FOUNDATION-859

PoC resolution in v4: #427

v5 implementation: UI5/cli#1309

### Performance
There's a slight performance degradation after the update. This is an
expected behaviour as the code behind the generated validation function
has evolved. They have added more comprehensive checks in there and more
verbose logging. This is clearly visible in the coverage reports that we
have integrated for tha function in our test scenarios.

#### Comparisson

Command: `time ui5 build`

##### sap.m

###### After
info ProjectBuilder Build succeeded in 18 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  36.37s user 11.09s system 246% cpu 19.237 total

###### Before
info ProjectBuilder Build succeeded in 17 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  35.54s user 10.14s system 247% cpu 18.480 total

---

##### sap.ui.core

###### After
info ProjectBuilder Build succeeded in 9.42 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  23.09s user 5.16s system 276% cpu 10.212 total

###### Before
info ProjectBuilder Build succeeded in 9.43 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  22.54s user 5.43s system 273% cpu 10.242 total
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants