Conversation
just an additional if/else
|
this works now! I think we can go ahead and merge soon. but we may want to add more tests first? |
|
@dtm2451 and @syellamilli adding you both as reviewers to this PR. Major changes to outputs are:
Will this break anything for you all? Otherwise this adds a working (!) example test that checks md5s for all generated non-PDF files. We need to expand to more tests, but very excited that it finally works. I think we should wait to merge until we add a few more tests though. |
|
My plan for the major workflow tests are demuxlet & freemuxlet (merged + un-merged which the test data checks) for each pipeline script (pre_qc, pre_fmx_qc, post_qc, post_fmx_qc). I want these same tests for CITE + VDJ, but I don't have the VDJ test data. I'll try to set up for CITE soon. I've been running into a few challenges/blockers with this. I'm listing them below with their status.
|
|
@dtm2451 @syellamilli: other minor update -- I do have two sets of toy data for TCR/BCR/CITE, one that can be used for running cellranger and one for post cellranger. Let me know if you want to play with these. |
No description provided.