Add src parameter to WireVector, Output, and Register - #512
Open
timsherwood wants to merge 1 commit into
Open
Conversation
timsherwood
force-pushed
the
feature/wirevector-src-param
branch
from
August 13, 2026 01:50
d4d3b26 to
60185e6
Compare
timsherwood
force-pushed
the
feature/wirevector-src-param
branch
from
August 13, 2026 01:53
60185e6 to
5c9666c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #512 +/- ##
=============================================
+ Coverage 93.8% 93.8% +0.1%
=============================================
Files 30 30
Lines 7174 7178 +4
=============================================
+ Hits 6724 6729 +5
+ Misses 450 449 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for putting this together! Some questions/comments:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srcparameter toWireVector,Output, andRegisterconstructors, allowing wire connections at construction time.WireVectorandOutput,src=xis equivalent towire <<= x.Register,src=xis equivalent toreg.next <<= x.Example
Notes
InputandConstdo not acceptsrc(raisesTypeError).reg = Register(src=reg + 1)are not possible; usereg.next <<= reg + 1for those cases.blockparameter is moved to the last position in all affected constructors for consistency.Test plan
WireVector,Output, andRegistersrcusage, bitwidth inference, coercion, and negative cases