fix(coverage): printf spy no longer breaks coverage collection#726
Merged
Conversation
…data Spying or mocking the printf builtin in a test shadowed the bare printf calls in coverage flush_buffer, redirecting the buffered coverage write to the spy instead of the data file. All coverage for that test was silently lost. Flush with `builtin printf` to bypass the shadow. Closes #724
JesusValeraDev
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #724
Spying or mocking the
printfbuiltin in a test silently dropped all coverage data for that test, because coverage's buffer flush used a bareprintfthat the test double shadowed — the buffered write went to the spy instead of the coverage data file.💡 Changes
builtin printfso a userprintfspy/mock cannot shadow the writeflush_bufferstill writes whenprintfis spied