feat(runner): add per-test timeout to abort hanging tests#725
Merged
Conversation
Add an opt-in `--test-timeout <seconds>` flag and `BASHUNIT_TEST_TIMEOUT` env var. When set, a test that runs longer than the threshold is killed and reported as a failure, then the run continues instead of hanging forever (e.g. a mock left without an implementation that blocks on input). The test body runs as a backgrounded job in its own process group so a watchdog can SIGTERM/SIGKILL the whole tree; a hanging test typically blocks in a child process that signalling the subshell alone cannot reach. Disabled by default (0), needs no external `timeout` command and works on Bash 3.2+ (including the default macOS Bash). Also reset the accumulated per-test exit code before parsing each result, so a non-zero/timed-out test no longer poisons the next test in the file. Closes #721
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #721
A test that hangs forever (e.g. a mock left without an implementation that blocks on input) currently hangs the whole run. This adds an opt-in threshold to kill such a test and keep going.
💡 Changes
--test-timeout <seconds>flag andBASHUNIT_TEST_TIMEOUTenv var; a test exceeding the limit fails and the run continues. Disabled by default.timeoutcommand needed); works on Bash 3.2+ including default macOS Bash.