Add notebooks to docs download - #652
Merged
Merged
Conversation
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
…into add_notebook_dl
…into add_notebook_dl
added 2 commits
October 9, 2025 09:52
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
penelopeysm
suggested changes
Oct 23, 2025
penelopeysm
left a comment
penelopeysm
left a comment
Contributor
There was a problem hiding this comment.
Just a parsing detail, otherwise happy.
Contributor
|
thinking about this a bit more - there is one benefit to using Julia - which is that we don't have to write hacky parsers that try to detect which packages are being imported - we can just use JuliaSyntax.jl... |
Contributor
|
darn, I don't like that I thought about that |
Contributor
|
OK, I think this is ready to go live! |
Member
|
Thanks, @penelopeysm @AoifeHughes! Just tried it - really helpful feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was to try and fix #642 as I was afraid of a caching issue, please see that PR for previous discussions