Skip to content

add GraphAr parser in importor#277

Closed
jiajunly wants to merge 0 commit intoTuGraph-family:masterfrom
jiajunly:master
Closed

add GraphAr parser in importor#277
jiajunly wants to merge 0 commit intoTuGraph-family:masterfrom
jiajunly:master

Conversation

@jiajunly
Copy link
Copy Markdown
Contributor

@jiajunly jiajunly commented Aug 15, 2023

To support GraphAr graph data import.

  1. support vertex column parser.
  2. support edge column parser.
  3. Dockerfile and ci
  4. parse GraphAr graph.yml
  5. add comment
  6. add tests
  7. reject the same edge label with different properties

TODO:

  1. fix ci error
  2. test the data with null type

Copy link
Copy Markdown
Collaborator

@qishipengqsp qishipengqsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

其他整体问题:

  1. 添加注释
  2. 补充相应的Unit Test和Integrate Test

Comment thread CMakeLists.txt Outdated
Comment thread CMakeLists.txt Outdated
Comment thread ci/images/tugraph-compile-centos7-Dockerfile Outdated
Comment thread ci/images/tugraph-compile-centos8-Dockerfile Outdated
Comment thread ci/images/tugraph-compile-ubuntu18.04-Dockerfile Outdated
Comment thread src/import/column_parser.h Outdated
Comment thread src/import/column_parser.h Outdated
Comment thread src/import/column_parser.h Outdated
Comment thread src/import/column_parser.h Outdated
Comment thread src/import/import_v3.cpp
Comment thread ci/images/tugraph-compile-centos7-Dockerfile
Comment thread ci/images/tugraph-compile-centos8-Dockerfile
Comment thread ci/images/tugraph-compile-ubuntu18.04-Dockerfile
Comment thread test/integration/test_import_gar.py Outdated
Comment thread test/test_import_gar.cpp Outdated
Comment thread test/test_import_gar.cpp Outdated
Comment thread test/test_import_gar.cpp Outdated
Copy link
Copy Markdown
Collaborator

@qishipengqsp qishipengqsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外检查一下你所有的auto,auto是调用copy constructor的,尽量用auto&

Comment thread src/import/graphar_config.h Outdated
Comment thread src/import/graphar_config.h Outdated
Comment thread src/import/graphar_parser.h Outdated
Comment thread src/import/graphar_parser.h Outdated
Comment thread src/import/graphar_parser.h Outdated
Comment thread src/import/graphar_parser.h Outdated
Comment thread src/import/graphar_parser.h Outdated
Comment thread src/import/graphar_parser.h Outdated
Comment thread src/import/import_v3.cpp Outdated
Comment thread test/integration/test_import_gar.py Outdated
Comment thread src/import/graphar_config.h Outdated
Comment thread src/import/graphar_config.h Outdated
Comment thread src/import/graphar_parser.cpp Outdated
Comment thread src/import/graphar_config.h Outdated
Comment thread src/import/graphar_parser.cpp Outdated
Comment thread src/import/graphar_parser.cpp Outdated
Comment thread test/resource/data/gar_test/edge_test/movie.graph.yml Outdated
@jiajunly jiajunly closed this Jan 25, 2024
@qishipengqsp qishipengqsp reopened this Jan 26, 2024
@jiajunly
Copy link
Copy Markdown
Contributor Author

It is ready for review.😀 @qishipengqsp @acezen

@qishipengqsp qishipengqsp changed the title GraphAr parser add GraphAr parser in importor Jun 25, 2024
@jiajunly jiajunly closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants