Skip to content

🌐 Added Polish translation#136

Open
krakowiak wants to merge 3 commits intoTryGhost:mainfrom
krakowiak:add-polish-translation
Open

🌐 Added Polish translation#136
krakowiak wants to merge 3 commits intoTryGhost:mainfrom
krakowiak:add-polish-translation

Conversation

@krakowiak
Copy link
Copy Markdown

@krakowiak krakowiak commented Apr 7, 2026

Added locales/pl.json with Polish translations for theme strings.


Note

Low Risk
Low risk: adds a new translation JSON file only, with no logic or runtime behavior changes beyond enabling Polish text when selected.

Overview
Adds Polish localization by introducing locales/pl.json with translations for the theme’s existing strings (navigation, pagination, membership/paywall, and common UI labels).

Reviewed by Cursor Bugbot for commit 5a53579. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI review requested due to automatic review settings April 7, 2026 13:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

Walkthrough

A new Polish translation file (locales/pl.json) was added containing 112 lines of localized UI text mappings. The file provides Polish translations for pagination, navigation, archive/latest controls, search and metadata labels (e.g., “Comments”, “RSS”, “Website”), authentication UI (sign-in flow, email/password prompts), subscription/member-only messages (including {tiers} and paid-members-only notices), CTA texts (“Subscribe”, “Upgrade”, “Load more issues”), episode/post navigation, and dynamic template strings like {page}, {totalPages}, {numberOfIssues}, {numberOfPosts}, {authors}, and {primaryAuthor}.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title references adding a Polish translation, which directly aligns with the main change of adding a new locales/pl.json file with Polish UI strings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes the addition of Polish translations in locales/pl.json, which matches the changeset exactly.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: da5cf3b28f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

locales/pl.json Outdated
"By {primaryAuthor}": "Autor: {primaryAuthor}",
"Close (Esc)": "Zamknij (Esc)",
"Comments": "Komentarze",
"Don't miss out on the latest issues. Sign up now to get access to the library of members-only issues.": "Nie przegap najnowszych wydań. Zarejestruj się teraz i uzyskaj dostęp do biblioteki wydań tylko dla subskrybentów.",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Match canonical apostrophe in translation key

Use the exact source key spelling here: this entry uses Don't (ASCII apostrophe), but the canonical key in locales/en.json/locales/context.json is Don’t (typographic apostrophe). Because locale lookup is exact-string based, this Polish translation will never be selected and that sentence will fall back to English at runtime.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Polish (pl) locale support by introducing a new translation file for the theme’s UI strings.

Changes:

  • Added locales/pl.json containing Polish translations for existing theme i18n keys.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

locales/pl.json Outdated
"By {primaryAuthor}": "Autor: {primaryAuthor}",
"Close (Esc)": "Zamknij (Esc)",
"Comments": "Komentarze",
"Don't miss out on the latest issues. Sign up now to get access to the library of members-only issues.": "Nie przegap najnowszych wydań. Zarejestruj się teraz i uzyskaj dostęp do biblioteki wydań tylko dla subskrybentów.",
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translation key here uses a straight apostrophe ("Don't"), but the templates/context use a curly apostrophe ("Don’t"). Because i18n lookups are exact-match, this entry won’t be used and will leave the real key untranslated. Update the key to exactly match the canonical key string (curly apostrophe), keeping the Polish translation value the same.

Suggested change
"Don't miss out on the latest issues. Sign up now to get access to the library of members-only issues.": "Nie przegap najnowszych wydań. Zarejestruj się teraz i uzyskaj dostęp do biblioteki wydań tylko dla subskrybentów.",
"Dont miss out on the latest issues. Sign up now to get access to the library of members-only issues.": "Nie przegap najnowszych wydań. Zarejestruj się teraz i uzyskaj dostęp do biblioteki wydań tylko dla subskrybentów.",

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 5a53579. Configure here.

"comment": "komentarz",
"comments": "komentarze",
"in {primaryTag}": "w {primaryTag}",
"jamie@example.com": "jan@kowalski.pl",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder email uses potentially real domain instead of example

Medium Severity

The jamie@example.com placeholder in pl.json is translated to jan@kowalski.pl. This uses a common Polish surname as the domain, kowalski.pl, instead of the Polish word for "example" (przykład). This deviates from the convention in other locales, which localize "example" in the domain, and may reference a real registered domain, raising privacy concerns.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 5a53579. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants