CMakeLists.txt proposed fixes for building on Gentoo Linux - #957
Open
Anoncheg1 wants to merge 1 commit into
Open
CMakeLists.txt proposed fixes for building on Gentoo Linux#957Anoncheg1 wants to merge 1 commit into
Anoncheg1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I created Ebuild file for Gentoo Linux with instruction to compile package from sources.
https://github.com/Anoncheg1/anonch-overlay/blob/main/games-engines/opengothic/opengothic-1.0.3549.ebuild
it is for Dec 23 2025 abf079e
Motivation
Linux distributions (e.g., Gentoo, Arch, NixOS) strongly prefer linking against system-installed libraries for security updates, binary deduplication, and easier maintenance. Currently, packaging OpenGothic requires maintainers to apply fragile
sedpatches to strip out bundled submodules, which is prone to breaking on upstream updates.Changes
This PR introduces three new CMake options, all defaulting to
OFFto preserve the exact existing behavior for end-users building from source:USE_SYSTEM_ZENKIT: Uses systemzenkitandsquishlibraries.USE_SYSTEM_TEMPEST: Uses systemTempestandopenallibraries.USE_SYSTEM_BULLET: Uses systembulletlibraries viafind_package(Bullet).Benefits
cmake ..will experience no changes.-DUSE_SYSTEM_ZENKIT=ON -DUSE_SYSTEM_TEMPEST=ON -DUSE_SYSTEM_BULLET=ONto CMake, eliminating the need for ebuild/PKGBUILD patching.INTERFACE_LINK_LIBRARIES(e.g., systemzenkitlinks tosquish, systemTempestlinks toopenal), preventing "DSO missing from command line" linker errors.if()blocks that were left behind in the Bullet section.(Note: There is also a minor C++ deprecation warning in
game/world/objects/interactive.cppregardinginter.state. I recommend changing it tointer.state_countto ensure clean builds on modern compilers, but I have kept this PR strictly focused on CMake.)