Fix IndexError in folder namespace page_get_language method#548
Closed
Fix IndexError in folder namespace page_get_language method#548
Conversation
Co-authored-by: TrueBrain <1663690+TrueBrain@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] We are seeing an issue on Sentry:
IndexError
list index out of range
truewiki/namespaces/folder/namespace.py in page_get_language at line 93
The "page" variable is "Folder/Category". Can we fix this error?
Fix IndexError in folder namespace page_get_language method
Jul 3, 2025
Owner
|
@copilot we should also add an e2e test for this. |
Co-authored-by: TrueBrain <1663690+TrueBrain@users.noreply.github.com>
Author
Added e2e test in |
Owner
|
Okay, this was fun. But I will do this myself properly, with actually running flake and e2e tests :) Tnx though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
page_get_languagemethod intruewiki/namespaces/folder/namespace.pywas throwing anIndexError: list index out of rangewhen called with pages like "Folder/Category" that don't follow the expected path structure.Error Details:
truewiki/namespaces/folder/namespace.pyline 93page.split("/")[2]on a list with only 2 elementsRoot Cause
The method assumed all non-root/non-namespace-root pages would have at least 3 path components when split by "/", but pages like "Folder/Category" only have 2 components:
["Folder", "Category"].Solution
Added a bounds check before accessing the language component at index 2:
Testing
The fix handles all edge cases correctly:
Compatibility
Nonewhen no language component exists)This fix prevents the Sentry error while maintaining full backward compatibility with existing functionality.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.