fix: include config directory in hatch build#54
Conversation
|
The Fix the conflict and confirm the wheel contents, and I’ll merge. Great work keeping the packaging tight! |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThe ChangesBuild Packaging Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The config manifest files (builtin_commands.md, plugins.md) in trushell/config/ were not listed in the hatch build include list, which could cause a broken PyPI install where the kernel can't find any manifests. Fix: add 'trushell/config/*' to the include list in pyproject.toml. Verified: the built .whl contains both config files. Closes TruFoundation#48
34b2597 to
188bee5
Compare
Problem
The config manifest files (
builtin_commands.md,plugins.md) intrushell/config/are not listed in the hatch buildincludelist. Hatchling will include them implicitly only if they fall underpackages = ["trushell"], but the explicitincludelist may override that on some hatchling versions, causing a broken PyPI install where the kernel can't find any manifests.Closes #48
Fix
Add
trushell/config/*to theincludelist inpyproject.toml:Summary by CodeRabbit