Skip to content

feat(security): decouple transport tls from auth#428

Merged
yordis merged 1 commit into
masterfrom
yordis/feat-disable-tls-auth-split
Jul 7, 2026
Merged

feat(security): decouple transport tls from auth#428
yordis merged 1 commit into
masterfrom
yordis/feat-disable-tls-auth-split

Conversation

@yordis

@yordis yordis commented Jul 7, 2026

Copy link
Copy Markdown
Member
  • Some deployments need plaintext transport behind an existing trusted network boundary without losing authentication and authorization checks.
  • Operators need --insecure to keep its existing all-security-off meaning while having a narrower transport-only switch.
  • Runtime surfaces should report the selected transport security state without suggesting plaintext transport is fully secure.

@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

PR Summary

High Risk
Changes how transport security and auth interact at startup and on HTTP/TCP paths; misconfiguration could expose plaintext traffic or weaken expectations around --insecure.

Overview
Adds --disable-tls so operators can run plaintext HTTP/TCP while authentication and authorization stay on; --insecure still turns off auth, authorization, and TLS together.

ApplicationOptions gains DisableTls plus AuthDisabled() (Insecure only) and TlsDisabled() (Insecure or DisableTls). Startup and ClusterVNode wire TLS (certificates, secure endpoints, HTTPS, HTTP scheme) through TlsDisabled(), and passthrough vs real auth providers through AuthDisabled(). Trusted HTTP auth and Unix socket auth now require auth to remain enabled even when TLS is off; node certificate HTTP auth stays tied to TLS.

Program logs a dedicated TLS-disabled warning. The admin configuration browser shows "TLS disabled" with a warn tone when appropriate. Telemetry includes disableTls. Tests cover the new flag, insecure semantics, and a node that starts without certs with TLS off and internal auth still active.

Reviewed by Cursor Bugbot for commit 5dcb4f1. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yordis, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: de97dbeb-19b7-44f9-adcc-fd8f9328b3aa

📥 Commits

Reviewing files that changed from the base of the PR and between 1c446bf and 5dcb4f1.

📒 Files selected for processing (12)
  • src/EventStore.ClusterNode/AuthorizationPolicyRegistryFactory.cs
  • src/EventStore.ClusterNode/ClusterVNodeHostedService.cs
  • src/EventStore.ClusterNode/Components/Services/ConfigurationBrowserService.cs
  • src/EventStore.ClusterNode/Program.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_default_settings.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterNodeOptionsTests/when_building/with_secure_tcp.cs
  • src/EventStore.Core.XUnit.Tests/Configuration/ClusterVNodeOptionsTests.cs
  • src/EventStore.Core/Certificates/OptionsCertificateProvider.cs
  • src/EventStore.Core/ClusterVNode.cs
  • src/EventStore.Core/Configuration/ClusterVNodeOptions.cs
  • src/EventStore.Core/Configuration/ClusterVNodeOptionsValidator.cs
  • src/EventStore.Core/Telemetry/TelemetryService.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/feat-disable-tls-auth-split

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/feat-disable-tls-auth-split branch from 44a72bf to 5dcb4f1 Compare July 7, 2026 07:53
@yordis yordis merged commit 4a268d9 into master Jul 7, 2026
21 checks passed
@yordis yordis deleted the yordis/feat-disable-tls-auth-split branch July 7, 2026 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant