Add pre-commit hook for automatic Spotless formatting#5
Closed
nlaverdure wants to merge 3 commits into
Closed
Conversation
Moves the hook into a tracked .githooks/ directory and adds an installHooks Gradle task (wired to compileJava) that runs `git config core.hooksPath .githooks` on first build, so new contributors get the hook automatically without any manual setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
caparomula
reviewed
Jun 4, 2026
Contributor
There was a problem hiding this comment.
I'm not sure that running git diff --name-only | xargs -r git add is quite the right thing. It changes the behavior of git commit to stage all modified files, not just the ones that the user had staged. Second, the xargs invocation will choke on any files with whitespace in their name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.githooks/pre-commit(tracked in the repo) that runsspotlessApplyand re-stages any reformatted files before each commitinstallHooksGradle task wired tocompileJavathat runsgit config core.hooksPath .githooks— new contributors get the hook configured automatically on first build, no manual setup required