Skip to content

support TWW / Midnight multiple packet parsing #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alica228 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support TWW / Midnight multiple packet parsing #992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WowPacketParserModule.V8_0_1_27101/Parsers/MiscellaneousHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ public static void HandleMultiplePackets(Packet packet)
byte[] bytes = null;

len = packet.ReadUInt16();
opcode = packet.ReadUInt16();
opcode = packet.ReadInt32();

@MaxtorCoder MaxtorCoder Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add if check to this for AddedInVersion, this will break parsing for BFA, SL and start of TWW

bytes = packet.ReadBytes(len);

if (bytes == null || len == 0)
Expand Down