Issue 280 (Drawer-like behavior for the sidebar)#281
Issue 280 (Drawer-like behavior for the sidebar)#281andreacampi wants to merge 3 commits intoTreesaver:masterfrom
Conversation
…izeChrome() method (Treesaver#280).
…ger resizing of the chrome (Treesaver#280).
|
Looks good. If a smaller grid is selected when the sidebar is activated does it jump back up to the larger grid when the sidebar is put away or is the width bug still happening? |
|
No, it doesn't grow again. That's unfortunate... |
|
Is it ok if we leave this for a little while until we can address some of the implications of it? Because it is an optional flag, maybe it is ok for now. |
|
No problem, I use a private build of Treesaver anyway. I just wanted to get it out there. |
|
I can confirm that with the right CSS, it actually does grow back. Trick being that every class that sets the grid width (based on the amount of columns) needs a 'max-width' setting equal to (or one pixel below, to avoid scoring faults) the width of the next, with the exception of the last. E.g: (considering a column width of 280px, having a margin of 20px in case of multiple columns) Therefore it would be very worthwhile merging this in! |
In the second commit, we may want to add the
sidebar-drawer-activeclass to the chrome instead.