Skip to content

Ensured multi-gpu math does not divide by 0 or overshoot n_layers#1358

Merged
jlarson4 merged 1 commit into
devfrom
bug/multi-gpu-device-index-math
Jun 3, 2026
Merged

Ensured multi-gpu math does not divide by 0 or overshoot n_layers#1358
jlarson4 merged 1 commit into
devfrom
bug/multi-gpu-device-index-math

Conversation

@jlarson4
Copy link
Copy Markdown
Collaborator

@jlarson4 jlarson4 commented Jun 3, 2026

Description

Solution documented to the issue documented by @summer0517 on issue #1356. Ensures layers end up properly distributed on n_devices and does not error when n_layers is not perfectly divisible by n_devices.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@jlarson4 jlarson4 merged commit 393541f into dev Jun 3, 2026
69 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant