Skip to content

ハピラインふくい区間快速追加 - #1631

Open
mittan12 wants to merge 1 commit into
TrainLCD:devfrom
mittan12:patch-82
Open

ハピラインふくい区間快速追加#1631
mittan12 wants to merge 1 commit into
TrainLCD:devfrom
mittan12:patch-82

Conversation

@mittan12

@mittan12 mittan12 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

概要

変更の種類

  • バグ修正
  • 新機能
  • データの修正・追加
  • リファクタリング
  • ドキュメント
  • CI/CD
  • その他

変更内容

テスト

  • cargo fmt --all -- --check が通ること
  • cargo clippy -- -D warnings が通ること
  • cargo testSQLX_OFFLINE=true)が通ること

関連Issue

スクリーンショット(任意)

@mittan12
mittan12 requested a review from TinyKitten as a code owner August 12, 2026 11:19
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • data/5!station_station_types.csv is excluded by !**/*.csv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0fdd9233-d2e5-4fea-9d6a-85c0c4cff311

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🚉 停車駅の変更

1 件の新しい停車パターン

● 停車 / ○ 通過 / △ 一部通過 / ◆ 平日停車 / ◇ 休日停車 / ▲ 一部停車

🆕 区間快速 (Regional Rapid) - ハピラインふくい線

type_cd=108, line_group_cd=1171

変更内容: 13 駅追加

全駅リスト (13駅)
# 駅名 Station 停車
1 敦賀 Tsuruga
2 南今庄 Minami-Imajō
3 今庄 Imajō
4 湯尾 Yunoo
5 南条 Nanjō
6 王子保 Ōshio
7 しきぶ Shikibu
8 武生 Takefu
9 鯖江 Sabae
10 北鯖江 Kita-Sabae
11 大土呂 Ōdoro
12 越前花堂 Echizen-Hanando
13 福井 Fukui

@TinyKitten TinyKitten left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます!確認したい点がありますので、ご対応お願いします

DEFAULT,1141515,108,1171,1,湯尾
DEFAULT,1141516,108,1171,0,南条
DEFAULT,1141517,108,1171,1,王子保
DEFAULT,9942820,108,1171,1,しきぶ

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

しきぶ駅はWikipediaを見る限り区間快速では停車駅のようですが、いかがでしょうか?
https://ja.wikipedia.org/wiki/ハピラインふくい線

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらの確認ミスです。

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mittan12 であれば、該当の行の pass0 に変更いただけますでしょうか。

DEFAULT,1141515,108,1171,1,湯尾
DEFAULT,1141516,108,1171,0,南条
DEFAULT,1141517,108,1171,1,王子保
DEFAULT,9942820,108,1171,1,しきぶ

@TinyKitten TinyKitten Aug 13, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

しきぶは停車駅なので 0 にしてください。
他の駅の停車パターンも間違っている場合はそちらもご対応お願いします。

Suggested change
DEFAULT,9942820,108,1171,1,しきぶ
DEFAULT,9942820,108,1171,0,しきぶ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants