Promote staging to main: portfolio monitors, watchlist tools, and records refresh

[TradingGoose-Dev]

Summary

Promotes the current staging branch to main with three merged feature sets:

• Refreshes the Records order table/details experience, including provider order detail access and cleaner linked log handling.
• Adds workflow watchlist automation through a Watchlist block, watchlist tools, and shared structured listing identity flows.
• Generalizes monitor support from indicator-only monitors to source-aware indicator and portfolio monitors, including portfolio monitor configuration, runtime dispatch, socket reconciliation, and workflow trigger support.

Diff scope: upstream/main 605fd3f0 to upstream/staging 8a60dd62, 317 files changed.

Why

This promotes staged trading workflow improvements into main so production can use the latest records UI, watchlist automation, shared listing/provider selectors, and portfolio state monitor runtime.

Affected Areas

• apps/tradinggoose
• apps/docs
• packages/*
• Workflows / execution
• Realtime / sockets
• Market data / charting
• Dev tooling / CI / infra
• Documentation only
• Other: changelog/*

Issue Links( if any )

Refs #127
Refs #128
Refs #129

Validation

git fetch --all --prune
git log --oneline upstream/main..upstream/staging
git diff --shortstat upstream/main...upstream/staging
git diff --stat upstream/main...upstream/staging
git diff --name-only upstream/main...upstream/staging | rg '(^|/)migration(s)?(/|$)'

Results:

• Compared current parent refs: upstream/main 605fd3f0 and upstream/staging 8a60dd62.
• Confirmed included staging PRs: feat(records): refresh order table and details panel #127, feat(watchlist-tool): add workflow watchlist block and tools #128, and feat(monitors): add portfolio state monitor support #129.
• Confirmed diff size: 317 files changed, 10421 insertions, 5614 deletions.
• Confirmed no */migration/* files are touched.
• Automated app/test suite was not run for this PR body drafting pass.

Risk / Rollout Notes

• Roll out app, socket server, and background workers together because portfolio monitor runtime, reconcile routes, and pending monitor execution handling are coupled.
• Monitor APIs move from indicator-specific routes to source-aware /api/monitors routes.
• Trading holdings naming is replaced by portfolio detail naming across blocks, tools, API routes, and provider capability contracts.
• Watchlist automation now depends on structured listing identity instead of raw symbols or item ids.
• Backout: roll back this promotion to the current main deployment. No database migrations or env changes are included, so rollback should not require schema backout.

Config / Data Changes

• Env vars added or changed: none.
• Database schema or migration impact: none; no migration files touched.
• External services or provider behavior changed: trading provider capability naming and provider/account selection flows are updated; broker portfolio detail/order detail paths use the newer canonical provider contracts.

Screenshots / Video

Not captured in this PR body drafting pass.

Visible UI areas changed:

• Records order table/details panel
• Monitor configuration/editor surfaces
• Watchlist listing controls
• Shared market/trading provider selectors
• Workflow listing/provider sub-block controls

Checklist

• I kept the change focused and reviewed my own diff
• I validated the change locally and documented the results above
• I updated docs, examples, or copy if behavior/user-facing flows changed
• I called out any env, schema, provider, or rollout impact
• I did not include secrets, tokens, or private credentials in this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
studio (staging)	Ready	Preview, Comment	May 30, 2026 2:13am

[greptile-apps]

Greptile Summary

This staging-to-main promotion merges three feature sets: a refreshed Records order table with provider order detail access, a Watchlist block and tool suite for workflow automation, and generalized monitor support expanding from indicator-only to source-aware indicator and portfolio monitors with condition evaluation, runtime dispatch, socket reconciliation, and workflow trigger integration.

• Portfolio monitor runtime: New PortfolioMonitorRuntime subscribes to the portfolio manager's account-snapshot channel, evaluates fire conditions (edge vs. while_true, cooldown, crossing operators) against snapshots, enqueues monitor pending executions, and persists runtime state with optimistic concurrency. The indicator-monitor-runtime refactored to share the new monitor-runtime-lock helper and the widened AnyMarketProviderId type.
• Monitor API consolidation: Old /api/indicator-monitors/* routes are replaced by source-aware /api/monitors/* routes that dispatch to indicator or portfolio config builders by source field; notifyMonitorsReconcile fires on create/update/delete.
• Watchlist automation: New WatchlistBlock and four tool configs (readLists, readListItems, addListing, removeListing) use checkSessionOrInternalAuth to accept both session and workflow-internal requests; a new removeListingFromWatchlist operation resolves by ListingIdentity equality rather than item ID.

Confidence Score: 4/5

Safe to merge after addressing the pending-execution drain compatibility gap introduced by the executionType rename.

The executionType column value was renamed from 'indicator_monitor' to 'monitor' across the pending-execution stack. The drain's switch has no case for the old value, so any rows already in the table when workers are redeployed will hit default: throw, be logged but never completed, and re-enter the same failure loop every time the stale-processing window reclaims them. Indicator monitors fire on every market data tick, so in-flight rows are nearly certain at deploy time even in a coordinated rollout.

apps/tradinggoose/background/pending-execution-drain.ts and apps/tradinggoose/lib/execution/pending-execution.ts — the dropped 'indicator_monitor' case needs a backward-compat handler or a DB cleanup step before the new workers go live.

Important Files Changed

Filename	Overview
apps/tradinggoose/background/pending-execution-drain.ts	Renamed executionType case from 'indicator_monitor' to 'monitor' with no backward-compat path for pre-existing queued rows; orphaned rows will loop through claim → fail → stale-reclaim indefinitely.
apps/tradinggoose/lib/execution/pending-execution.ts	Drops 'indicator_monitor' from PendingExecutionType and replaces it with 'monitor'; no migration path for existing queued rows of the old type.
apps/tradinggoose/app/api/monitors/route.ts	New source-aware monitor create/list route generalizing from indicator-only to portfolio+indicator; auth, workspace permission, and reconcile-notify patterns look correct.
apps/tradinggoose/app/api/monitors/[id]/route.ts	New GET/PATCH/DELETE route for unified monitors with proper workspace ownership checks and optimistic-concurrency on PATCH; runtimeState is preserved when the effective config doesn't change.
apps/tradinggoose/socket-server/trading/portfolio-monitor-runtime.ts	New portfolio monitor runtime with shared lock helper, subscription lifecycle, edge/while_true fire modes, and optimistic-concurrency DB writes; non-firing state writes are now conditional on state transitions.
apps/tradinggoose/lib/monitors/portfolio-conditions.ts	New portfolio condition evaluator with full metric set, operator compatibility guard, and ListingIdentity-backed position matching; crosses_above/crosses_below correctly return false when no previous snapshot exists.
apps/tradinggoose/background/monitor-execution.ts	New dispatch shim that routes MonitorExecutionPayload to the correct handler by source; clean registry pattern.
apps/tradinggoose/blocks/blocks/watchlist.ts	New Watchlist block with readLists/readListItems/addListing/removeListing operations; listing field correctly uses LISTING_IDENTITY_VALUE_TYPE and fetchOptions for removeListing is scoped to the selected watchlist.
apps/tradinggoose/tools/watchlist/index.ts	New watchlist tool implementations; workspaceId is injected by the tool-execution framework for GET routes, POST mutations explicitly resolve it from _context.
apps/tradinggoose/app/api/watchlists/route.ts	Adds checkSessionOrInternalAuth for workflow tool access, and a new watchlistId lookup path on GET to support the readListItems tool.
apps/tradinggoose/providers/trading/portfolio-identity.ts	Renames tokenAccountId to credentialId in PortfolioIdentity, separating the public credential identifier from the internal OAuth token store key; getPortfolioIdentityKey updated consistently.
apps/tradinggoose/socket-server/trading/portfolio-manager.ts	Refactored to support server-side onData/onError callbacks for monitor runtime subscriptions; now uses authorizeTradingConnectionRequest for credential resolution and adds workspace access checks.

Sequence Diagram

sequenceDiagram
    participant PM as PortfolioManager
    participant PMR as PortfolioMonitorRuntime
    participant DB as Database
    participant PE as PendingExecution queue
    participant Drain as pending-execution-drain
    participant WF as Workflow execution

    PMR->>DB: reconcile() SELECT active portfolio monitors
    DB-->>PMR: monitor rows
    PMR->>PM: subscribeData(portfolioIdentity, onData)

    loop every pollIntervalSeconds
        PM->>PM: poll trading provider
        PM->>PMR: onData(account-snapshot)
        PMR->>PMR: evaluatePortfolioFireCondition()
        alt condition fires
            PMR->>DB: getCurrentProviderConfig() SELECT
            PMR->>PE: "enqueuePendingExecution type=monitor"
            PMR->>DB: updateRuntimeState() SELECT+UPDATE
        else state transition only
            PMR->>DB: updateRuntimeState() SELECT+UPDATE
        else no change
            PMR->>PMR: update in-memory state only
        end
    end

    Drain->>PE: claimNextPendingExecution()
    PE-->>Drain: "row executionType=monitor"
    Drain->>Drain: isMonitorExecutionPayload()
    Drain->>WF: executePortfolioMonitorJob()
    WF-->>Drain: result
    Drain->>PE: completePendingExecution()

Loading

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/tradinggoose/background/pending-execution-drain.ts:62-76
**Orphaned `indicator_monitor` rows after deployment**

`PendingExecutionType` dropped `'indicator_monitor'` and the drain's switch now handles only `'monitor'`. Any pending-execution row already in the DB with `executionType = 'indicator_monitor'` will hit the `default: throw` branch, be logged as an error, but never reach `completePendingExecution`. The row stays in its claimed state, is reclaimed after the 30-minute stale-processing window (`STALE_PROCESSING_WINDOW_MS`), and then fails in the same way on every subsequent drain invocation — creating an infinite failure loop for the entire lifetime of those rows.

Given that indicator monitors fire on every market data tick, there will almost certainly be in-flight `indicator_monitor` rows queued at the moment the workers are redeployed, even in a coordinated rollout. Adding a backward-compat case that immediately completes (or marks as failed) old-type rows would prevent this.

_{Reviews (3): Last reviewed commit: "fix(watchlist): fetch individual watchli..." | Re-trigger Greptile}

[TradingGoose-Dev]

@greptileai

[TradingGoose-Dev]

@greptileai