Persist Inbox read state to files#444
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Persist Inbox read/unread state in the OpenAlice data directory instead of browser localStorage.
data/inbox/entries.jsonlas the append-only Inbox notification log.data/inbox/read-state.jsonfor mutable per-entryreadAtstate.readAtfrom/api/inbox/historyso every client reads the same attention state.PUT /api/inbox/:id/readandDELETE /api/inbox/:id/readfor read/unread writes.readAt, with optimistic updates reconciled by the next history poll.Why
Inbox read state used to live in frontend localStorage (
openalice.inbox-read.v2). That survives a reload in one browser profile, but it resets across Electron/browser clients, different frontend instances, and app-mode debugging. App packaging exposed that as the wrong ownership boundary: read/unread is user attention state and should follow the OpenAlice data root, not the UI cache.The new sidecar file keeps mutable read state separate from the immutable Inbox event log, so marking an entry read does not rewrite
entries.jsonl.Validation
pnpm vitest run src/core/inbox-store.spec.ts src/webui/routes/inbox.spec.tsnpx tsc --noEmitcd ui && npx tsc -bpnpm testgit diff --check