Add Electron IPC transport and CLI smoke coverage#443
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves the desktop app path toward an Electron-native transport while keeping the browser/dev/Docker HTTP path intact.
app://openaliceloading and a preload bridge for renderer-to-Alice IPC.alice*andtraderhubshims do not require MCP or an exposed MCP port.electron:smoke:ptycoverage for renderer PTY attach and CLI socket manifest behavior.Why
Desktop app mode should not be forced through the same localhost web server shape used by browser/dev/Docker deployments. This reduces default port exposure, avoids fragile localhost coupling for the app shell, and keeps UTA separate because that process is intentionally designed as a detachable trusted trading sidecar.
The OpenCode cleanup closes the last obvious MCP injection trace: OpenCode now relies on the same CLI shim/tool socket path as the other agents, and inherited stale MCP/tool env is scrubbed before spawning sessions.
Validation
npx tsc --noEmitcd ui && npx tsc -bnpx tsc -p apps/desktop/tsconfig.json --noEmitpnpm vitest run src/workspaces/cli/shim.spec.ts src/server/cli.spec.tspnpm vitest run src/workspaces/adapters/ai-config.spec.ts src/workspaces/spawn-env.spec.tspnpm electron:build && pnpm electron:smoke:pty --skip-buildgit diff --check